Make it more clear when nothing is wrong

MadLittleMods · MadLittleMods · commit 3100b6379aed · 2025-10-30T11:10:24.000-05:00
See #19090 (comment)
diff --git a/synapse/logging/context.py b/synapse/logging/context.py
@@ -916,7 +916,7 @@ def run_in_background(
             )
         else:
             logcontext_debug_logger.debug(
-                "run_in_background(%s): deferred already completed and the function should have maintained the calling logcontext %s",
+                "run_in_background(%s): deferred already completed (maintained the calling logcontext %s)",
                 instance_id,
                 calling_context,
             )

Original file line number	Diff line number	Diff line change
`@@ -916,7 +916,7 @@ def run_in_background(`
`916`	`916`	`)`
`917`	`917`	`else:`
`918`	`918`	`logcontext_debug_logger.debug(`
`919`		`- "run_in_background(%s): deferred already completed and the function should have maintained the calling logcontext %s",`
	`919`	`+ "run_in_background(%s): deferred already completed (maintained the calling logcontext %s)",`
`920`	`920`	`instance_id,`
`921`	`921`	`calling_context,`
`922`	`922`	`)`