File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -100,8 +100,11 @@ def test_reset(self) -> None:
100100 This is emulated by jumping the stream ahead, then reconnecting (which
101101 sends the proper position and RDATA).
102102 """
103- # A huge RDATA log line is triggered in this test, which breaks trial
103+ # FIXME: Because huge RDATA log line is triggered in this test,
104+ # trial breaks, sometimes (flakily) failing the test run.
104105 # ref: https://github.com/twisted/twisted/issues/12482
106+ # To remove this, we would need to fix the above issue and
107+ # update, including in olddeps (so several years' wait).
105108 server_logger = logging .getLogger ("tests.server" )
106109 server_logger_was_disabled = server_logger .disabled
107110 server_logger .disabled = True
Original file line number Diff line number Diff line change @@ -649,9 +649,12 @@ def test_set_custom_field_profile_too_long(self) -> None:
649649 """
650650 Attempts to set a custom field that would push the overall profile too large.
651651 """
652- # Because we emit huge SQL log lines and trial sometimes crashes on these,
653- # disable SQL logging for this test
652+ # FIXME: Because we emit huge SQL log lines and trial can't handle these,
653+ # sometimes (flakily) failing the test run,
654+ # disable SQL logging for this test.
654655 # ref: https://github.com/twisted/twisted/issues/12482
656+ # To remove this, we would need to fix the above issue and
657+ # update, including in olddeps (so several years' wait).
655658 sql_logger = logging .getLogger ("synapse.storage.SQL" )
656659 sql_logger_was_disabled = sql_logger .disabled
657660 sql_logger .disabled = True
You can’t perform that action at this time.
0 commit comments