Skip to content

Commit 84cf43f

Browse files
committed
Fill in synapse/storage/database.py
1 parent 4785287 commit 84cf43f

1 file changed

Lines changed: 13 additions & 5 deletions

File tree

synapse/storage/database.py

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
current_context,
6262
make_deferred_yieldable,
6363
)
64-
from synapse.metrics import LaterGauge, register_threadpool
64+
from synapse.metrics import SERVER_NAME_LABEL, LaterGauge, register_threadpool
6565
from synapse.metrics.background_process_metrics import run_as_background_process
6666
from synapse.storage.background_updates import BackgroundUpdater
6767
from synapse.storage.engines import BaseDatabaseEngine, PostgresEngine, Sqlite3Engine
@@ -82,9 +82,13 @@
8282
transaction_logger = logging.getLogger("synapse.storage.txn")
8383
perf_logger = logging.getLogger("synapse.storage.TIME")
8484

85-
sql_scheduling_timer = Histogram("synapse_storage_schedule_time", "sec")
85+
sql_scheduling_timer = Histogram(
86+
"synapse_storage_schedule_time", "sec", labelnames=[SERVER_NAME_LABEL]
87+
)
8688

87-
sql_query_timer = Histogram("synapse_storage_query_time", "sec", ["verb"])
89+
sql_query_timer = Histogram(
90+
"synapse_storage_query_time", "sec", labelnames=["verb", SERVER_NAME_LABEL]
91+
)
8892
sql_txn_count = Counter("synapse_storage_transaction_time_count", "sec", ["desc"])
8993
sql_txn_duration = Counter("synapse_storage_transaction_time_sum", "sec", ["desc"])
9094

@@ -493,7 +497,9 @@ def _do_execute(
493497
finally:
494498
secs = time.time() - start
495499
sql_logger.debug("[SQL time] {%s} %f sec", self.name, secs)
496-
sql_query_timer.labels(sql.split()[0]).observe(secs)
500+
sql_query_timer.labels(
501+
verb=sql.split()[0], **{SERVER_NAME_LABEL: self.server_name}
502+
).observe(secs)
497503

498504
def close(self) -> None:
499505
self.txn.close()
@@ -1006,7 +1012,9 @@ def inner_func(conn: _PoolConnection, *args: P.args, **kwargs: P.kwargs) -> R:
10061012
operation_name="db.connection",
10071013
):
10081014
sched_duration_sec = monotonic_time() - start_time
1009-
sql_scheduling_timer.observe(sched_duration_sec)
1015+
sql_scheduling_timer.labels(
1016+
**{SERVER_NAME_LABEL: self.server_name}
1017+
).observe(sched_duration_sec)
10101018
context.add_database_scheduled(sched_duration_sec)
10111019

10121020
if self._txn_limit > 0:

0 commit comments

Comments
 (0)