Fix detection of workflow failures in the release script. (#18211)

reivilibre · web-flow · commit a278c0d852a0 · 2025-03-13T14:52:00.000Z
If one workflow is successful and one fails, currently that is reported
as success.

---------

Signed-off-by: Olivier 'reivilibre &lt;oliverw@matrix.org&gt;
diff --git a/changelog.d/18211.misc b/changelog.d/18211.misc
@@ -0,0 +1 @@
+Fix detection of workflow failures in the release script.
diff --git a/scripts-dev/release.py b/scripts-dev/release.py
@@ -592,7 +592,7 @@ def _wait_for_actions(gh_token: Optional[str]) -> None:
         if all(
             workflow["status"] != "in_progress" for workflow in resp["workflow_runs"]
         ):
-            success = (
+            success = all(
                 workflow["status"] == "completed" for workflow in resp["workflow_runs"]
             )
             if success:

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Fix detection of workflow failures in the release script.`
Original file line number	Diff line number	Diff line change
`@@ -592,7 +592,7 @@ def _wait_for_actions(gh_token: Optional[str]) -> None:`
`592`	`592`	`if all(`
`593`	`593`	`workflow["status"] != "in_progress" for workflow in resp["workflow_runs"]`
`594`	`594`	`):`
`595`		`- success = (`
	`595`	`+ success = all(`
`596`	`596`	`workflow["status"] == "completed" for workflow in resp["workflow_runs"]`
`597`	`597`	`)`
`598`	`598`	`if success:`