Use twisted.internet.testing module in tests instead of deprecated twisted.test.proto_helpers. (#18728)

Follows: #18727

---------

Signed-off-by: Olivier 'reivilibre <oliverw@matrix.org>

Author: reivilibre

changelog.d/18728.misc

@@ -0,0 +1 @@
+Use `twisted.internet.testing` module in tests instead of deprecated `twisted.test.proto_helpers`.

tests/api/test_auth.py

@@ -23,7 +23,7 @@
 
 import pymacaroons
 
-from twisted.test.proto_helpers import MemoryReactor
+from twisted.internet.testing import MemoryReactor
 
 from synapse.api.auth.internal import InternalAuth
 from synapse.api.auth_blocking import AuthBlocking

tests/api/test_filtering.py

@@ -25,7 +25,7 @@
 
 import jsonschema
 
-from twisted.test.proto_helpers import MemoryReactor
+from twisted.internet.testing import MemoryReactor
 
 from synapse.api.constants import EduTypes, EventContentFields
 from synapse.api.errors import SynapseError

tests/api/test_urls.py

@@ -13,7 +13,7 @@
 #
 
 
-from twisted.test.proto_helpers import MemoryReactor
+from twisted.internet.testing import MemoryReactor
 
 from synapse.api.urls import LoginSSORedirectURIBuilder
 from synapse.server import HomeServer

tests/app/test_openid_listener.py

@@ -22,7 +22,7 @@
 
 from parameterized import parameterized
 
-from twisted.test.proto_helpers import MemoryReactor
+from twisted.internet.testing import MemoryReactor
 
 from synapse.app.generic_worker import GenericWorkerServer
 from synapse.app.homeserver import SynapseHomeServer

tests/appservice/test_api.py

@@ -21,7 +21,7 @@
 from typing import Any, List, Mapping, Optional, Sequence, Union
 from unittest.mock import Mock
 
-from twisted.test.proto_helpers import MemoryReactor
+from twisted.internet.testing import MemoryReactor
 
 from synapse.appservice import ApplicationService
 from synapse.server import HomeServer

tests/appservice/test_scheduler.py

@@ -24,7 +24,7 @@
 from typing_extensions import TypeAlias
 
 from twisted.internet import defer
-from twisted.test.proto_helpers import MemoryReactor
+from twisted.internet.testing import MemoryReactor
 
 from synapse.appservice import (
     ApplicationService,

tests/config/test_room_directory.py

@@ -19,7 +19,7 @@
 #
 import yaml
 
-from twisted.test.proto_helpers import MemoryReactor
+from twisted.internet.testing import MemoryReactor
 
 import synapse.rest.admin
 import synapse.rest.client.login

tests/crypto/test_keyring.py

@@ -31,7 +31,7 @@
 
 from twisted.internet import defer
 from twisted.internet.defer import Deferred, ensureDeferred
-from twisted.test.proto_helpers import MemoryReactor
+from twisted.internet.testing import MemoryReactor
 
 from synapse.api.errors import SynapseError
 from synapse.crypto import keyring

tests/events/test_auto_accept_invites.py

@@ -27,7 +27,7 @@
 import attr
 from parameterized import parameterized
 
-from twisted.test.proto_helpers import MemoryReactor
+from twisted.internet.testing import MemoryReactor
 
 from synapse.api.constants import EventTypes
 from synapse.api.errors import SynapseError