Skip to content

Commit a6e3265

Browse files
Fix Failed to stop metrics warnings in request metrics (#18753)
``` Failed to stop metrics: TypeError("prometheus_client.metrics.MetricWrapperBase.labels() got multiple values for keyword argument 'server_name'") ``` Noticed while running and debugging some tests. This bug was introduced in #18724
1 parent cd339d5 commit a6e3265

2 files changed

Lines changed: 1 addition & 1 deletion

File tree

changelog.d/18753.misc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Refactor `Histogram` metrics to be homeserver-scoped.

synapse/http/request_metrics.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,6 @@ def stop(self, time_sec: float, response_code: int, sent_bytes: int) -> None:
243243
response_timer.labels(
244244
code=response_code_str,
245245
**response_base_labels,
246-
**{SERVER_NAME_LABEL: self.our_server_name},
247246
).observe(time_sec - self.start_ts)
248247

249248
resource_usage = context.get_resource_usage()

0 commit comments

Comments
 (0)