Skip to content

Commit b1953a9

Browse files
committed
Merge pull request #354 from matrix-org/markjh/SYN-513
SYN-513: Include updates for rooms that have had all their tags deleted
2 parents dd40fb6 + bbe10e8 commit b1953a9

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

synapse/handlers/sync.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ def full_state_sync_for_joined_room(self, room_id, sync_config,
272272
def private_user_data_for_room(self, room_id, tags_by_room):
273273
private_user_data = []
274274
tags = tags_by_room.get(room_id)
275-
if tags:
275+
if tags is not None:
276276
private_user_data.append({
277277
"type": "m.tag",
278278
"content": {"tags": tags},

synapse/storage/tags.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,7 @@ def get_updated_tags_txn(txn):
9595
if room_ids:
9696
tags_by_room = yield self.get_tags_for_user(user_id)
9797
for room_id in room_ids:
98-
if room_id in tags_by_room:
99-
results[room_id] = tags_by_room[room_id]
98+
results[room_id] = tags_by_room.get(room_id, {})
10099

101100
defer.returnValue(results)
102101

0 commit comments

Comments
 (0)