Skip to content

Commit b34342e

Browse files
authored
MSC4306: register the thread subscriptions servlet in the client servlet section (#18726)
The MSC4306 endpoints were never registered, and thus never made available, even if the experimental feature flag was enabled.
1 parent b7e7f53 commit b34342e

3 files changed

Lines changed: 7 additions & 2 deletions

File tree

changelog.d/18726.bugfix

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Register the MSC4306 endpoints in the CS API when the experimental feature is enabled.

synapse/rest/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@
6363
sync,
6464
tags,
6565
thirdparty,
66+
thread_subscriptions,
6667
tokenrefresh,
6768
user_directory,
6869
versions,
@@ -122,6 +123,7 @@
122123
login_token_request.register_servlets,
123124
rendezvous.register_servlets,
124125
auth_metadata.register_servlets,
126+
thread_subscriptions.register_servlets,
125127
)
126128

127129
SERVLET_GROUPS: Dict[str, Iterable[RegisterServletsFunc]] = {

synapse/rest/client/thread_subscriptions.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
from http import HTTPStatus
2-
from typing import Tuple
2+
from typing import TYPE_CHECKING, Tuple
33

44
from synapse._pydantic_compat import StrictBool
55
from synapse.api.errors import Codes, NotFoundError, SynapseError
@@ -10,10 +10,12 @@
1010
)
1111
from synapse.http.site import SynapseRequest
1212
from synapse.rest.client._base import client_patterns
13-
from synapse.server import HomeServer
1413
from synapse.types import JsonDict, RoomID
1514
from synapse.types.rest import RequestBodyModel
1615

16+
if TYPE_CHECKING:
17+
from synapse.server import HomeServer
18+
1719

1820
class ThreadSubscriptionsRestServlet(RestServlet):
1921
PATTERNS = client_patterns(

0 commit comments

Comments
 (0)