Skip to content

Commit c8d0f97

Browse files
committed
Cancelling the deferred doesn't matter AFACT
See #18914 for more docs on how deferreds interact with logcontexts
1 parent 160eb63 commit c8d0f97

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

synapse/util/clock.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,8 +156,7 @@ def wrapped_f(*args: P.args, **kwargs: P.kwargs) -> Deferred:
156156
# in the sentinel context now.
157157
#
158158
# We want to start the task in the `sentinel` logcontext, to avoid leaking the
159-
# current context into the reactor after the function finishes. TODO: Or perhaps
160-
# someone cancels the looping call (does this matter?).
159+
# current context into the reactor after the function finishes.
161160
with context.PreserveLoggingContext():
162161
d = call.start(msec / 1000.0, now=now)
163162
d.addErrback(log_failure, "Looping call died", consumeErrors=False)

0 commit comments

Comments
 (0)