Skip to content

Handle abnormal MySQL structure_load death gracefully #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greg-rychlewski merged 7 commits into from
Mar 29, 2026
Merged

Handle abnormal MySQL structure_load death gracefully #723

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d93fbd4
handle process dying gracefully
greg-rychlewski Mar 29, 2026
c14f47c
fix test
greg-rychlewski Mar 29, 2026
21debd9
test
greg-rychlewski Mar 29, 2026
2d76c3b
test
greg-rychlewski Mar 29, 2026
ecf52dd
test
greg-rychlewski Mar 29, 2026
b541c12
test
greg-rychlewski Mar 29, 2026
ba48be7
restore old trap exit
greg-rychlewski Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test
  • Loading branch information
@greg-rychlewski
greg-rychlewski committed Mar 29, 2026
commit b541c12a85859fa500004694211b999028e41636
3 changes: 1 addition & 2 deletions lib/ecto/adapters/myxql.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,7 +594,6 @@ defmodule Ecto.Adapters.MyXQL do
Port.command(port, contents)
# Use this as a signal to close the port since we cannot
# send an exit command to mysql in batch mode
Process.sleep(10000)
Port.command(port, ";SELECT '__ECTO_EOF__';\n")
collect_output(port, "")
end
Expand Down Expand Up @@ -660,7 +659,7 @@ defmodule Ecto.Adapters.MyXQL do
{acc, 1}

{^port, {:exit_status, status}} ->
{acc, status}
collect_output(port, acc)
end
end
end
Loading
⚡