TCP ICE first iteration (#238)

Author: sgfn

examples/echo/mix.lock

@@ -8,7 +8,7 @@
   "elixir_make": {:hex, :elixir_make, "0.9.0", "6484b3cd8c0cee58f09f05ecaf1a140a8c97670671a6a0e7ab4dc326c3109726", [:mix], [], "hexpm", "db23d4fd8b757462ad02f8aa73431a426fe6671c80b200d9710caf3d1dd0ffdb"},
   "elixir_uuid": {:hex, :elixir_uuid, "1.2.1", "dce506597acb7e6b0daeaff52ff6a9043f5919a4c3315abb4143f0b00378c097", [:mix], [], "hexpm", "f7eba2ea6c3555cea09706492716b0d87397b88946e6380898c2889d68585752"},
   "ex_dtls": {:hex, :ex_dtls, "0.18.0", "0815e3384bb0c1e6c06559012479cf9a94a501ddf46c3df54dc2d1b169e29d5c", [:mix], [{:bundlex, "~> 1.5.3", [hex: :bundlex, repo: "hexpm", optional: false]}, {:unifex, "~> 1.0", [hex: :unifex, repo: "hexpm", optional: false]}], "hexpm", "562eda1815eeaed8360b2b5c34d4db5b453794bc096404a4c64f193fa7b18bf2"},
-  "ex_ice": {:hex, :ex_ice, "0.15.0", "17e1d85818facb05d6b6dbd4b0012f80e9250c6077f59b9018fc0841522396e6", [:mix], [{:elixir_uuid, "~> 1.0", [hex: :elixir_uuid, repo: "hexpm", optional: false]}, {:ex_stun, "~> 0.2.0", [hex: :ex_stun, repo: "hexpm", optional: false]}, {:ex_turn, "~> 0.2.0", [hex: :ex_turn, repo: "hexpm", optional: false]}], "hexpm", "aea6e95072a1e3aee0c2c84b669125b147562da78756af5db13b8e5a3ee44333"},
+  "ex_ice": {:git, "https://github.com/elixir-webrtc/ex_ice.git", "5316de5106c193874e26c092f8147ce0dd9afaa1", []},
   "ex_libsrtp": {:hex, :ex_libsrtp, "0.7.2", "211bd89c08026943ce71f3e2c0231795b99cee748808ed3ae7b97cd8d2450b6b", [:mix], [{:bunch, "~> 1.6", [hex: :bunch, repo: "hexpm", optional: false]}, {:bundlex, "~> 1.3", [hex: :bundlex, repo: "hexpm", optional: false]}, {:membrane_precompiled_dependency_provider, "~> 0.1.0", [hex: :membrane_precompiled_dependency_provider, repo: "hexpm", optional: false]}, {:unifex, "~> 1.1", [hex: :unifex, repo: "hexpm", optional: false]}], "hexpm", "2e20645d0d739a4ecdcf8d4810a0c198120c8a2f617f2b75b2e2e704d59f492a"},
   "ex_rtcp": {:hex, :ex_rtcp, "0.4.0", "f9e515462a9581798ff6413583a25174cfd2101c94a2ebee871cca7639886f0a", [:mix], [], "hexpm", "28956602cf210d692fcdaf3f60ca49681634e1deb28ace41246aee61ee22dc3b"},
   "ex_rtp": {:hex, :ex_rtp, "0.4.0", "1f1b5c1440a904706011e3afbb41741f5da309ce251cb986690ce9fd82636658", [:mix], [], "hexpm", "0f72d80d5953a62057270040f0f1ee6f955c08eeae82ac659c038001d7d5a790"},

lib/ex_webrtc/peer_connection.ex

@@ -612,6 +612,7 @@ defmodule ExWebRTC.PeerConnection do
     ice_config = [
       ice_servers: config.ice_servers,
       ice_transport_policy: config.ice_transport_policy,
+      transport: config.ice_transport_protocol,
       ip_filter: config.ice_ip_filter,
       aggressive_nomination: config.ice_aggressive_nomination,
       host_to_srflx_ip_mapper: config.host_to_srflx_ip_mapper,

lib/ex_webrtc/peer_connection/configuration.ex

@@ -154,6 +154,8 @@ defmodule ExWebRTC.PeerConnection.Configuration do
 
   * `controlling_process` - a pid of a process where all messages will be sent. `self()` by default,
   * `ice_servers` - list of STUN/TURN servers to use. By default, no servers are provided.
+  * `ice_transport_protocol` - which transport protocol should be used. Defaults to `:udp`.
+  Note that relay candidates for TCP transport are not yet supported.
   * `ice_transport_policy` - which type of ICE candidates should be used. Defaults to `:all`.
   * `ice_ip_filter` - filter applied when gathering local candidates. By default, all IP addresses are accepted.
   * `ice_port_range` - range of ports that ICE will use for gathering host candidates. Defaults to ephemeral ports.
@@ -197,6 +199,7 @@ defmodule ExWebRTC.PeerConnection.Configuration do
   @type options() :: [
           controlling_process: Process.dest(),
           ice_servers: [ice_server()],
+          ice_transport_protocol: :udp | :tcp,
           ice_transport_policy: :relay | :all,
           ice_ip_filter: ICEAgent.ip_filter(),
           ice_port_range: Enumerable.t(non_neg_integer()),
@@ -219,6 +222,7 @@ defmodule ExWebRTC.PeerConnection.Configuration do
   @type t() :: %__MODULE__{
           controlling_process: Process.dest(),
           ice_servers: [ice_server()],
+          ice_transport_protocol: :udp | :tcp,
           ice_transport_policy: :relay | :all,
           ice_ip_filter: (:inet.ip_address() -> boolean()) | nil,
           ice_port_range: Enumerable.t(non_neg_integer()),
@@ -242,6 +246,7 @@ defmodule ExWebRTC.PeerConnection.Configuration do
               [
                 ice_servers: [],
                 ice_transport_policy: :all,
+                ice_transport_protocol: :udp,
                 ice_port_range: [0],
                 ice_aggressive_nomination: false,
                 host_to_srflx_ip_mapper: nil,

lib/ex_webrtc/rtp_receiver/nack_generator.ex

@@ -95,7 +95,7 @@ defmodule ExWebRTC.RTPReceiver.NACKGenerator do
         end
       end)
 
-    if length(missing_sn) != 0 do
+    if missing_sn != [] do
       feedback = NACK.from_sequence_numbers(sender_ssrc, media_ssrc, missing_sn)
       generator = %__MODULE__{generator | lost_packets: lost_packets}
 

mix.exs

@@ -62,7 +62,7 @@ defmodule ExWebRTC.MixProject do
   defp deps do
     [
       {:ex_sdp, "~> 1.1"},
-      {:ex_ice, "~> 0.15.0"},
+      {:ex_ice, github: "elixir-webrtc/ex_ice"},
       {:ex_dtls, "~> 0.18.0"},
       {:ex_libsrtp, "~> 0.7.1"},
       {:ex_rtp, "~> 0.4.0"},

mix.lock

@@ -12,14 +12,14 @@
   "erlex": {:hex, :erlex, "0.2.7", "810e8725f96ab74d17aac676e748627a07bc87eb950d2b83acd29dc047a30595", [:mix], [], "hexpm", "3ed95f79d1a844c3f6bf0cea61e0d5612a42ce56da9c03f01df538685365efb0"},
   "ex_doc": {:hex, :ex_doc, "0.38.2", "504d25eef296b4dec3b8e33e810bc8b5344d565998cd83914ffe1b8503737c02", [:mix], [{:earmark_parser, "~> 1.4.44", [hex: :earmark_parser, repo: "hexpm", optional: false]}, {:makeup_c, ">= 0.1.0", [hex: :makeup_c, repo: "hexpm", optional: true]}, {:makeup_elixir, "~> 0.14 or ~> 1.0", [hex: :makeup_elixir, repo: "hexpm", optional: false]}, {:makeup_erlang, "~> 0.1 or ~> 1.0", [hex: :makeup_erlang, repo: "hexpm", optional: false]}, {:makeup_html, ">= 0.1.0", [hex: :makeup_html, repo: "hexpm", optional: true]}], "hexpm", "732f2d972e42c116a70802f9898c51b54916e542cc50968ac6980512ec90f42b"},
   "ex_dtls": {:hex, :ex_dtls, "0.18.0", "0815e3384bb0c1e6c06559012479cf9a94a501ddf46c3df54dc2d1b169e29d5c", [:mix], [{:bundlex, "~> 1.5.3", [hex: :bundlex, repo: "hexpm", optional: false]}, {:unifex, "~> 1.0", [hex: :unifex, repo: "hexpm", optional: false]}], "hexpm", "562eda1815eeaed8360b2b5c34d4db5b453794bc096404a4c64f193fa7b18bf2"},
-  "ex_ice": {:hex, :ex_ice, "0.15.0", "17e1d85818facb05d6b6dbd4b0012f80e9250c6077f59b9018fc0841522396e6", [:mix], [{:elixir_uuid, "~> 1.0", [hex: :elixir_uuid, repo: "hexpm", optional: false]}, {:ex_stun, "~> 0.2.0", [hex: :ex_stun, repo: "hexpm", optional: false]}, {:ex_turn, "~> 0.2.0", [hex: :ex_turn, repo: "hexpm", optional: false]}], "hexpm", "aea6e95072a1e3aee0c2c84b669125b147562da78756af5db13b8e5a3ee44333"},
+  "ex_ice": {:git, "https://github.com/elixir-webrtc/ex_ice.git", "5316de5106c193874e26c092f8147ce0dd9afaa1", []},
   "ex_libsrtp": {:hex, :ex_libsrtp, "0.7.2", "211bd89c08026943ce71f3e2c0231795b99cee748808ed3ae7b97cd8d2450b6b", [:mix], [{:bunch, "~> 1.6", [hex: :bunch, repo: "hexpm", optional: false]}, {:bundlex, "~> 1.3", [hex: :bundlex, repo: "hexpm", optional: false]}, {:membrane_precompiled_dependency_provider, "~> 0.1.0", [hex: :membrane_precompiled_dependency_provider, repo: "hexpm", optional: false]}, {:unifex, "~> 1.1", [hex: :unifex, repo: "hexpm", optional: false]}], "hexpm", "2e20645d0d739a4ecdcf8d4810a0c198120c8a2f617f2b75b2e2e704d59f492a"},
   "ex_rtcp": {:hex, :ex_rtcp, "0.4.0", "f9e515462a9581798ff6413583a25174cfd2101c94a2ebee871cca7639886f0a", [:mix], [], "hexpm", "28956602cf210d692fcdaf3f60ca49681634e1deb28ace41246aee61ee22dc3b"},
   "ex_rtp": {:hex, :ex_rtp, "0.4.0", "1f1b5c1440a904706011e3afbb41741f5da309ce251cb986690ce9fd82636658", [:mix], [], "hexpm", "0f72d80d5953a62057270040f0f1ee6f955c08eeae82ac659c038001d7d5a790"},
   "ex_sctp": {:hex, :ex_sctp, "0.1.2", "ee004e114bf0a485058b8caedfa7d01125e845782647a19e3fd99f5d086a9a8f", [:mix], [{:rustler, "~> 0.36.0", [hex: :rustler, repo: "hexpm", optional: false]}], "hexpm", "cc752b5bee8ff730a3d9c8899a921e1ba78009fd2904f94a0e6d89c9b76860ed"},
   "ex_sdp": {:hex, :ex_sdp, "1.1.3", "e2c45ebc44551261cf1a9b3f46ad2ed470fce5aa342b656193df8996e5cf9994", [:mix], [{:bunch, "~> 1.3", [hex: :bunch, repo: "hexpm", optional: false]}, {:elixir_uuid, "~> 1.2", [hex: :elixir_uuid, repo: "hexpm", optional: false]}], "hexpm", "0ed765b9d519511186a9afa7e4123286744d838065b0974fe85bdd2f2cae1ef7"},
   "ex_stun": {:hex, :ex_stun, "0.2.0", "feb1fc7db0356406655b2a617805e6c712b93308c8ea2bf0ba1197b1f0866deb", [:mix], [], "hexpm", "1e01ba8290082ccbf37acaa5190d1f69b51edd6de2026a8d6d51368b29d115d0"},
-  "ex_turn": {:hex, :ex_turn, "0.2.0", "4e1f9b089e9a5ee44928d12370cc9ea7a89b84b2f6256832de65271212eb80de", [:mix], [{:ex_stun, "~> 0.2.0", [hex: :ex_stun, repo: "hexpm", optional: false]}], "hexpm", "08e884f0af2c4a147e3f8cd4ffe33e3452a256389f0956e55a8c4d75bf0e74cd"},
+  "ex_turn": {:hex, :ex_turn, "0.2.1", "a38d1083caa2b20f77297bb5625c9ee22c8d870c39aaece708fae95fb629c706", [:mix], [{:ex_stun, "~> 0.2.0", [hex: :ex_stun, repo: "hexpm", optional: false]}], "hexpm", "f8719c1baca765a53239b6fdcc4ba65a6a27a21c18e8d66b52ce9cd3f2b510ba"},
   "excoveralls": {:hex, :excoveralls, "0.18.5", "e229d0a65982613332ec30f07940038fe451a2e5b29bce2a5022165f0c9b157e", [:mix], [{:castore, "~> 1.0", [hex: :castore, repo: "hexpm", optional: true]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "523fe8a15603f86d64852aab2abe8ddbd78e68579c8525ae765facc5eae01562"},
   "file_system": {:hex, :file_system, "1.1.0", "08d232062284546c6c34426997dd7ef6ec9f8bbd090eb91780283c9016840e8f", [:mix], [], "hexpm", "bfcf81244f416871f2a2e15c1b515287faa5db9c6bcf290222206d120b3d43f6"},
   "finch": {:hex, :finch, "0.19.0", "c644641491ea854fc5c1bbaef36bfc764e3f08e7185e1f084e35e0672241b76d", [:mix], [{:mime, "~> 1.0 or ~> 2.0", [hex: :mime, repo: "hexpm", optional: false]}, {:mint, "~> 1.6.2 or ~> 1.7", [hex: :mint, repo: "hexpm", optional: false]}, {:nimble_options, "~> 0.4 or ~> 1.0", [hex: :nimble_options, repo: "hexpm", optional: false]}, {:nimble_pool, "~> 1.1", [hex: :nimble_pool, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "fc5324ce209125d1e2fa0fcd2634601c52a787aff1cd33ee833664a5af4ea2b6"},

test/ex_webrtc/peer_connection/configuration_test.exs

@@ -81,6 +81,7 @@ defmodule ExWebRTC.PeerConnection.ConfigurationTest do
       assert %Configuration{
                ice_servers: [],
                ice_transport_policy: :all,
+               ice_transport_protocol: :udp,
                audio_codecs: [%RTPCodecParameters{rtcp_fbs: []}],
                video_codecs: [%RTPCodecParameters{rtcp_fbs: []}],
                audio_extensions: [@mid_ext],