Skip to content

Commit 0bd369f

Browse files
committed
Get tests passing again
1 parent c0be10d commit 0bd369f

2 files changed

Lines changed: 19 additions & 11 deletions

File tree

app/services/ember-cli.js

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,9 @@ export default Ember.Service.extend({
164164
usePods: false,
165165

166166
setup(gist) {
167-
return this._getTwiddleJson(gist);
167+
return this._getTwiddleJson(gist).catch(() => {
168+
// do nothing if no twiddle.json
169+
});
168170
},
169171

170172
generate(type) {
@@ -238,12 +240,12 @@ export default Ember.Service.extend({
238240
this.addBoilerPlateFiles(out, gist);
239241
this.addConfig(out, gist);
240242

241-
this.getTwiddleJson(gist).then(twiddleJson => {
243+
resolve(this.getTwiddleJson(gist).then(twiddleJson => {
242244
// Add boot code
243245
contentForAppBoot(out, {modulePrefix: twiddleAppName, dependencies: twiddleJson.dependencies});
244246

245-
resolve(this.buildHtml(gist, out.join('\n'), cssOut.join('\n'), twiddleJson));
246-
});
247+
return RSVP.resolve(this.buildHtml(gist, out.join('\n'), cssOut.join('\n'), twiddleJson));
248+
}));
247249
});
248250

249251
return promise;
@@ -356,7 +358,11 @@ export default Ember.Service.extend({
356358
reject();
357359
}
358360

359-
twiddleJson = JSON.parse(twiddleJson.get('content'));
361+
try {
362+
twiddleJson = JSON.parse(twiddleJson.get('content'));
363+
} catch(error) {
364+
reject(error);
365+
}
360366

361367
// set usePods
362368
this.set('usePods', (twiddleJson.options && twiddleJson.options['use_pods']) || false);

tests/helpers/wait-for-loaded-iframe.js

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,18 @@ export default function(app, url) {
44
let iframe_window;
55

66
andThen(function() {
7-
iframe_window = outputPane();
87

98
// Wait until iframe loads
109
return new Ember.RSVP.Promise(function (resolve) {
11-
function onWindowLoad() {
12-
iframe_window.removeEventListener('load', onWindowLoad);
13-
resolve();
14-
}
10+
Ember.run.schedule('afterRender', () => {
11+
function onWindowLoad() {
12+
iframe_window.removeEventListener('load', onWindowLoad);
13+
resolve();
14+
}
1515

16-
iframe_window.addEventListener('load', onWindowLoad);
16+
iframe_window = outputPane();
17+
iframe_window.addEventListener('load', onWindowLoad);
18+
});
1719
});
1820
});
1921

0 commit comments

Comments
 (0)