Remove unused options

The inspector used to support filtering out components in the view
tab, and there are a lot of supporting code for that. Since the
view tab was removed, there is no longer any way to set this option,
and it is always true in practice.

Author: chancancode

app/controllers/component-tree.js

@@ -98,7 +98,6 @@ export default Controller.extend({
    */
   pinnedObjectId: null,
   inspectingViews: false,
-  components: true,
   viewTreeLoaded: false,
 
   /**
@@ -159,9 +158,6 @@ export default Controller.extend({
   init() {
     this._super(...arguments);
     this.set('expandedStateCache', {});
-    this.options = {
-      components: true
-    };
   },
 
   /**

app/routes/component-tree.js

@@ -19,7 +19,6 @@ export default TabRoute.extend({
     this.port.on('view:inspectDOMNode', this, this.inspectDOMNode);
 
     this.set('controller.viewTreeLoaded', false);
-    this.port.send('view:setOptions', { options: this.get('controller.options') });
     this.port.send('view:getTree');
   },
 

ember_debug/libs/glimmer-tree.js

@@ -43,7 +43,6 @@ export default class {
    * @param {Object} options
    *  - {owner}      owner           The Ember app's owner.
    *  - {Function}   retainObject    Called to retain an object for future inspection.
-   *  - {Object}     options         Options whether to show components or not.
    *  - {Object}     durations       Hash containing time to render per view id.
    *  - {Function}   highlightRange  Called to highlight a range of elements.
    *  - {Object}     ObjectInspector Used to inspect models.
@@ -52,29 +51,19 @@ export default class {
   constructor({
     owner,
     retainObject,
-    options,
     durations,
     highlightRange,
     objectInspector,
     viewRegistry
   }) {
     this.owner = owner;
     this.retainObject = retainObject;
-    this.options = options;
     this.durations = durations;
     this.highlightRange = highlightRange;
     this.objectInspector = objectInspector;
     this.viewRegistry = viewRegistry;
   }
 
-  /**
-   * @method updateOptions
-   * @param {Object} options
-   */
-  updateOptions(options) {
-    this.options = options;
-  }
-
   /**
    * @method updateDurations
    * @param {Object} durations
@@ -84,8 +73,7 @@ export default class {
   }
 
   /**
-   * Builds the view tree. The view tree may or may not contain
-   * components depending on the current options.
+   * Builds the view tree.
    *
    * The view tree has the top level outlet as the root of the tree.
    * The format is:
@@ -114,7 +102,7 @@ export default class {
   build() {
     if (this.getRoot()) {
       let outletTree = this.buildOutletTree();
-      let componentTrees = this.options.components ? this.buildComponentTrees(outletTree) : [];
+      let componentTrees = this.buildComponentTrees(outletTree);
       return this.addComponentsToOutlets(outletTree, componentTrees);
     }
   }

ember_debug/view-debug.js

@@ -75,11 +75,7 @@ export default EmberObject.extend(PortMixin, {
         this.inspectElement(element);
       }
     },
-    setOptions({ options }) {
-      this.set('options', options);
-      this.glimmerTree.updateOptions(options);
-      this.sendTree();
-    },
+
     sendModelToConsole(message) {
       const model = this.glimmerTree.modelForViewNodeValue(message);
 
@@ -96,7 +92,6 @@ export default EmberObject.extend(PortMixin, {
     this._super(...arguments);
 
     this.retainedObjects = [];
-    this.options = {};
     this._durations = {};
     layerDiv = document.createElement('div');
     layerDiv.setAttribute('data-label', 'layer-div');
@@ -126,7 +121,6 @@ export default EmberObject.extend(PortMixin, {
       owner: this.getOwner(),
       retainObject: this.retainObject.bind(this),
       highlightRange: this._highlightRange.bind(this),
-      options: this.get('options'),
       objectInspector: this.get('objectInspector'),
       durations: this._durations,
       viewRegistry: this.get('viewRegistry')
@@ -305,10 +299,11 @@ export default EmberObject.extend(PortMixin, {
 
   shouldShowView(view) {
     if (view instanceof Component) {
-      return this.options.components;
+      return true;
+    } else {
+      return (this.hasOwnController(view) || this.hasOwnContext(view)) &&
+        (!view.get('isVirtual') || this.hasOwnController(view) || this.hasOwnContext(view));
     }
-    return (this.hasOwnController(view) || this.hasOwnContext(view)) &&
-      (!view.get('isVirtual') || this.hasOwnController(view) || this.hasOwnContext(view));
   },
 
   hasOwnController(view) {
@@ -548,7 +543,6 @@ export default EmberObject.extend(PortMixin, {
       return false;
     }
     return this._nodeHasOwnController(renderNode, parentNode) &&
-      (this.options.components || !(this._nodeIsEmberComponent(renderNode))) &&
       (this._nodeHasViewInstance(renderNode) || this._nodeHasOwnController(renderNode, parentNode));
   },
 

tests/ember_debug/view-debug-test.js

@@ -147,16 +147,7 @@ module('Ember Debug - View', function(hooks) {
 
     let tree = message.tree;
     let simple = tree.children[0];
-    assert.equal(simple.children.length, 0, 'Components are not listed by default.');
-    run(() => {
-      port.trigger('view:setOptions', { options: { components: true } });
-    });
-
-    await settled();
-
-    tree = message.tree;
-    simple = tree.children[0];
-    assert.equal(simple.children.length, 1, 'Components can be configured to show.');
+    assert.equal(simple.children.length, 1, 'Components are shown.');
     let component = simple.children[0];
     assert.equal(component.value.viewClass, 'App.TestFooComponent');
   });