Use buffered writer for multipart temp files

Author: gi0baro

.github/workflows/build.yml

@@ -118,6 +118,8 @@ jobs:
         shell: bash
       - name: Generate PGO data
         shell: bash
+        env:
+          PGO_RUN: y
         run: |
           uv python install ${{ env.UV_PYTHON }}
           uv venv .venv

src/multipart/parse.rs

@@ -272,9 +272,9 @@ impl MultiPartParser {
 
                 let state = mem::take(&mut self.state);
                 match state {
-                    MultiPartParserState::File(part) => {
+                    MultiPartParserState::File(mut part) => {
                         // potentially allow py threads?
-                        part.file.as_ref().unwrap().sync_data()?;
+                        part.file.as_mut().unwrap().flush()?;
                         self.stack.push_back(Node::File(part));
                     }
                     _ => unreachable!(),

src/multipart/parts.rs

@@ -3,7 +3,7 @@ use http::header::{self, HeaderMap};
 use pyo3::{exceptions::PyStopIteration, prelude::*, types::PyBytes};
 use std::{
     fs::File,
-    io::{BufReader, Read},
+    io::{BufReader, BufWriter, Read},
     path::PathBuf,
     sync::Mutex,
 };
@@ -44,7 +44,7 @@ pub(super) struct FilePart {
     pub name: String,
     filename: Option<String>,
     path: PathBuf,
-    pub file: Option<File>,
+    pub file: Option<BufWriter<File>>,
     pub size: Option<usize>,
     tempdir: Option<PathBuf>,
 }
@@ -61,8 +61,7 @@ impl FilePart {
         let tempdir = Some(path.clone());
         path.push(TextNonce::sized_urlsafe(32).unwrap().into_string());
 
-        let file = File::create(path.clone())?;
-
+        let file = BufWriter::with_capacity(131_072, File::create(path.clone())?);
         Ok(FilePart {
             headers,
             name,

tests/multipart/test_multipart.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import os
 from pathlib import Path
 
 import pytest
@@ -383,6 +384,7 @@ def test_multipart_request_file_save(tmpdir: Path, multipart_save_client):
         assert f1.read() == f2.read()
 
 
+@pytest.mark.skipif(bool(os.getenv("PGO_RUN")), reason="PGO build")
 def test_multipart_request_file_stream(tmpdir: Path, multipart_stream_client):
     path = tmpdir / "test.txt"
     target = tmpdir / "save.txt"
@@ -400,6 +402,7 @@ def test_multipart_request_file_stream(tmpdir: Path, multipart_stream_client):
         assert f1.read() == f2.read()
 
 
+@pytest.mark.skipif(bool(os.getenv("PGO_RUN")), reason="PGO build")
 def test_multipart_request_file_copy(tmpdir: Path, multipart_copy_client):
     path = tmpdir / "test.txt"
     target = tmpdir / "save.txt"