Do not list related field choices in OPTIONS requests.#4021
Do not list related field choices in OPTIONS requests.#4021lovelydinosaur merged 1 commit intoencode:masterfrom
Conversation
…tadata. Listing related fields can leak sensitive data and result in poor performance when dealing with large result sets. Large result sets should be exposed by a dedicated endpoint instead.
69c69b8 to
a6732e2
Compare
|
I'm tempted to move this through the deprecation path. |
|
I have deprecation path in mind, I'll submit it in a few moment. |
|
Thanks ! |
|
I'd probably be okay with us simply dropping this in a median version, so long as we call it out. |
|
Could this be merged? This fixes #3751 which is a security (and major performance) issue so seems important to get it in. |
|
Great stuff, thank you! |
|
Hey guys, Fantastic library and great work overall. For those that actually do use this feature, will there be an opt-in workaround[1]? I looked at the merge commit and it seems like a blanket check for all related fields. It's pretty convenient to build a form off a single OPTIONS request. Thanks for all your work, Silvio [1]: Mandatory: https://xkcd.com/1172/ |
|
You'd need to use a custom metadata class, overriding |
|
Related example of overriding |
Listing related fields can leak sensitive data and result in poor performance
when dealing with large result sets.
Large result sets should be exposed by a dedicated endpoint instead.