Add support for page_size parameter in CursorPaginator class#5250
Merged
carltongibson merged 1 commit intoencode:masterfrom Sep 25, 2017
Merged
Add support for page_size parameter in CursorPaginator class#5250carltongibson merged 1 commit intoencode:masterfrom
carltongibson merged 1 commit intoencode:masterfrom
Conversation
Contributor
|
Hiya! The code looks good, but I'm still in two minds about if we should accept extra behavior on the already-complex cursor pagination. Not sure how to best take a judgement on this right now. |
Contributor
Author
|
@tomchristie I actually don't understand where is that complexity you mention. In pagination you have two concepts:
The only doubt I have here is about the role of |
|
I hope this can be merged in at some point, because we really like this feature at The Atlantic. Ignoring the extensive unit tests, it's only a little bit more code and makes the |
rpkilby
approved these changes
Sep 21, 2017
Collaborator
|
OK, let's have this. I was going to say "Needs Docs" but Thanks for the effort @cypreess! |
carltongibson
added a commit
that referenced
this pull request
Sep 25, 2017
carltongibson
added a commit
that referenced
this pull request
Sep 26, 2017
carltongibson
added a commit
that referenced
this pull request
Sep 27, 2017
carltongibson
added a commit
that referenced
this pull request
Sep 28, 2017
carltongibson
added a commit
that referenced
this pull request
Oct 5, 2017
carltongibson
added a commit
that referenced
this pull request
Oct 5, 2017
carltongibson
pushed a commit
that referenced
this pull request
Oct 6, 2017
* Set version number for 3.7.0 release * Rename release notes section Moved issue links to top for easier access. (Can move back later) * Add release note for #5273 * Add release note for #5440 * Add release note for #5265 Strict JSON handling * Add release note for #5250 * Add release notes for #5170 * Add release notes for #5443 * Add release notes for #5448 * Add release notes for #5452 * Add release not for #5342 * Add release notes for 5454 * Add release notes for #5058 & #5457 Remove Django 1.8 & 1.9 from README and setup.py * Release notes for merged 3.6.5 milestone tickets Tickets migrated to 3.7.0 milestone. * Add release notes for #5469 * Add release notes from AM 2ndOct * Add final changes to the release notes. * Add date and milestone link Move issue links back to bottom. * Update translations from transifex * Begin releae anouncement * Add release note for #5482 * 3.7 release announcement & related docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CursorPaginatorreceives identical support for page size query parameter asPageNumberPagination.Solving #5249