Skip to content

Don't make the content mandatory in the generic content form#5372

Merged
lovelydinosaur merged 1 commit intoencode:masterfrom
dvarrazzo:content-not-mandatory
Sep 4, 2017
Merged

Don't make the content mandatory in the generic content form#5372
lovelydinosaur merged 1 commit intoencode:masterfrom
dvarrazzo:content-not-mandatory

Conversation

@dvarrazzo
Copy link
Copy Markdown
Contributor

Sometimes, probably in the upgrade from Django 1.9 to 1.10, a post with
empty content is forbidden by javascript, with the message "Please fill
in this field". Filling the form with '{}' allows an application/json
request to be submitted.

The API call itself works perfectly well with a post with empty content:
the interface shouldn't make assumptions about it.

Sometimes, probably in the upgrade from Django 1.9 to 1.10, a post with
empty content is forbidden by javascript, with the message "Please fill
in this field". Filling the form with '{}' allows an application/json
request to be submitted.

The API call itself works perfectly well with a post with empty content:
the interface shouldn't make assumptions about it.
@lovelydinosaur
Copy link
Copy Markdown
Contributor

Fair enough! :)

@lovelydinosaur lovelydinosaur merged commit e42eb42 into encode:master Sep 4, 2017
@lovelydinosaur lovelydinosaur added this to the 3.6.5 Release milestone Sep 4, 2017
@dvarrazzo dvarrazzo deleted the content-not-mandatory branch September 4, 2017 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants