[enzyme-adapter-utils, enzyme-adapter-react-13] [fix] shallow: throw on mixed children/dangerouslySetInnerHTML

Author: ljharb

packages/enzyme-adapter-react-13/src/ReactThirteenElementToTree.js

@@ -27,8 +27,19 @@ export default function elementToTree(el) {
   } else if (typeof children !== 'undefined') {
     rendered = elementToTree(children);
   }
+
+  const nodeType = nodeTypeFromType(type);
+
+  if (nodeType === 'host' && props.dangerouslySetInnerHTML) {
+    if (props.children != null) {
+      const error = new Error('Can only set one of `children` or `props.dangerouslySetInnerHTML`.');
+      error.name = 'Invariant Violation';
+      throw error;
+    }
+  }
+
   return {
-    nodeType: nodeTypeFromType(type),
+    nodeType,
     type,
     props,
     key: ensureKeyOrUndefined(key),

packages/enzyme-adapter-utils/src/Utils.js

@@ -201,8 +201,19 @@ export function elementToTree(el, recurse = elementToTree) {
   } else if (typeof children !== 'undefined') {
     rendered = recurse(children);
   }
+
+  const nodeType = nodeTypeFromType(type);
+
+  if (nodeType === 'host' && props.dangerouslySetInnerHTML) {
+    if (props.children != null) {
+      const error = new Error('Can only set one of `children` or `props.dangerouslySetInnerHTML`.');
+      error.name = 'Invariant Violation';
+      throw error;
+    }
+  }
+
   return {
-    nodeType: nodeTypeFromType(type),
+    nodeType,
     type,
     props,
     key: ensureKeyOrUndefined(key),

packages/enzyme-test-suite/test/ReactWrapper-spec.jsx

@@ -91,6 +91,13 @@ describeWithDOM('mount', () => {
     });
 
     describe('wrapping invalid elements', () => {
+      it('throws with combined dangerouslySetInnerHTML and children on host nodes', () => {
+        /* eslint react/no-danger-with-children: 0 */
+        expect(() => mount((
+          <div dangerouslySetInnerHTML={{ __html: '{}' }}>child</div>
+        ))).to.throw(Error, 'Can only set one of `children` or `props.dangerouslySetInnerHTML`.');
+      });
+
       itIf(is('>= 16'), 'throws when mounting Portals', () => {
         const portal = createPortal(
           <div />,

packages/enzyme-test-suite/test/ShallowWrapper-spec.jsx

@@ -85,6 +85,13 @@ describe('shallow', () => {
     });
 
     describe('wrapping invalid elements', () => {
+      it('throws with combined dangerouslySetInnerHTML and children on host nodes', () => {
+        /* eslint react/no-danger-with-children: 0 */
+        expect(() => shallow((
+          <div dangerouslySetInnerHTML={{ __html: '{}' }}>child</div>
+        ))).to.throw(Error, 'Can only set one of `children` or `props.dangerouslySetInnerHTML`.');
+      });
+
       itIf(is('>= 16'), 'throws when shallow rendering Portals', () => {
         const portal = createPortal(
           <div />,