feat(no-promise-in-callback): add exemptDeclarations option#513
Merged
aladdin-add merged 1 commit intoeslint-community:mainfrom Dec 17, 2024
Merged
feat(no-promise-in-callback): add exemptDeclarations option#513aladdin-add merged 1 commit intoeslint-community:mainfrom
no-promise-in-callback): add exemptDeclarations option#513aladdin-add merged 1 commit intoeslint-community:mainfrom
Conversation
brettz9
force-pushed
the
exemptDeclarations
branch
from
96816c3 to
e8928b8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #513 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 25 29 +4
Lines 649 812 +163
Branches 250 318 +68
==========================================
+ Hits 649 812 +163 ☔ View full report in Codecov by Sentry. |
brettz9
force-pushed
the
exemptDeclarations
branch
2 times, most recently
from
7ec440a to
57df46a
Compare
brettz9
force-pushed
the
exemptDeclarations
branch
2 times, most recently
from
13fa1d5 to
1948aed
Compare
brettz9
force-pushed
the
exemptDeclarations
branch
from
1948aed to
9293950
Compare
MichaelDeBoey
approved these changes
Oct 29, 2024
aladdin-add
approved these changes
Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
What changes did you make? (Give an overview)
For
no-promise-in-callback, add anexemptDeclarationsoption to prevent reporting when the promise is within function declarations.Fixes #445