feat: add no-invalid-named-grid-areas rule#169
Merged
Conversation
lumirlumir
added
the
accepted
nzakas
previously approved these changes
Jun 10, 2025
nzakas
left a comment
nzakas
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks! Would like another review before merging.
snitin315
reviewed
Jun 21, 2025
snitin315
reviewed
Jun 21, 2025
snitin315
reviewed
Jun 21, 2025
snitin315
reviewed
Jun 21, 2025
snitin315
reviewed
Jun 26, 2025
nzakas
approved these changes
Jun 26, 2025
nzakas
left a comment
nzakas
left a comment
Member
There was a problem hiding this comment.
LGTM. Would like @snitin315 to verify before merging.
github-project-automation
Bot
moved this from Second Review Needed
to Complete
in Triage
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
This PR adds a new rule
no-invalid-named-grid-areasto enforce valid named grid area definitions in CSS Grid templates. The rule helps prevent common mistakes when using grid-template-areas and related properties by checking that named grid areas are properly defined according to the CSS Grid specification.What changes did you make? (Give an overview)
Added the
no-invalid-named-grid-areasrule, along with documentation and tests.Related Issues
Fixes #158
Is there anything you'd like reviewers to focus on?