feat: allow relative-size and global values in relative-font-units#214
Merged
Conversation
Tanujkanti4441
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR! Everything looks good, just a minor change request.
nzakas
reviewed
Jul 29, 2025
nzakas
left a comment
Member
There was a problem hiding this comment.
Thanks for taking a look at this.
There is no such thing as a math keyword in CSS, there are only math functions. Please update the logic and docs to take this into account.
Contributor
Author
|
@nzakas |
Member
|
Huh. I didn't realize that was a literal value, I thought it was a reference to the math functions. TIL. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
To update the
relative-font-unitsrule to more clearly and strictly enforce the use of relative font units, while always allowing relative-size keywords and global values, and always disallowing absolute-size keywords.What changes did you make? (Give an overview)
smallerandlargerrelative-size keywords.inherit,initial,revert,revert-layer, andunset.xx-small,x-small,small,medium,large,x-large,xx-large,xxx-large) and themathkeyword.Related Issues
Fixes #193
Is there anything you'd like reviewers to focus on?