feat: add selector-complexity rule#252
Merged
Merged
Conversation
1 task
lumirlumir
added
the
accepted
fasttime
reviewed
Sep 19, 2025
fasttime
left a comment
fasttime
left a comment
Member
There was a problem hiding this comment.
Excited to see this rule taking shape. I noticed that currently the rule only reports on a single node in the selector:
This is different from Stylelint, which reports on the whole selector (#foo #bar #baz) when a it finds a problem:
I believe that reporting on the whole selector would be less confusing because it's not obvious which part of a selector should be changed to comply with the rule. Thoughts?
fasttime
reviewed
Sep 28, 2025
fasttime
reviewed
Sep 29, 2025
fasttime
reviewed
Sep 30, 2025
fasttime
reviewed
Sep 30, 2025
fasttime
approved these changes
Oct 1, 2025
fasttime
left a comment
fasttime
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks! Leaving open for a second review before merging.
github-project-automation
Bot
moved this from Second Review Needed
to Complete
in Triage
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
To add a new rule to limit CSS selectors.
What changes did you make? (Give an overview)
Added a new rule called
selector-complexitywith following options:maxIdsmaxClassesmaxTypesmaxAttributesmaxPseudoClassesmaxUniversalsmaxCompoundsmaxCombinatorsdisallowCombinatorsdisallowPseudoClassesdisallowPseudoElementsdisallowAttributesdisallowAttributeMatchersRelated Issues
Fixes #19
Is there anything you'd like reviewers to focus on?