fix: enforce valid allow* values in prefer-logical-properties rule#311
Merged
nzakas merged 1 commit intoOct 27, 2025
Merged
Conversation
1 task
Tanujkanti4441
added
the
accepted
Tanujkanti4441
approved these changes
Oct 27, 2025
Tanujkanti4441
left a comment
Tanujkanti4441
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks!
Would like another review on this.
github-project-automation
Bot
moved this from Second Review Needed
to Complete
in Triage
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
This PR updates the
prefer-logical-propertiesrule to enforce that theallowPropertiesandallowUnitsoptions only accept valid, known CSS properties and units. Previously, invalid values were silently ignored.What changes did you make? (Give an overview)
allowPropertiesandallowUnitsonly accept values present inpropertiesReplacementsandunitReplacements.uniqueItems: trueplacement inrelative-font-unitsschema.Related Issues
Fixes #303
Is there anything you'd like reviewers to focus on?