Skip to content

fix: Suppress var() validation errors#45

Merged
mdjermanovic merged 1 commit into
mainfrom
property-vars
Jan 15, 2025
Merged

fix: Suppress var() validation errors#45
mdjermanovic merged 1 commit into
mainfrom
property-vars

Conversation

@nzakas

@nzakas nzakas commented Jan 14, 2025

Copy link
Copy Markdown
Member

Prerequisites checklist

What is the purpose of this pull request?

Ensure that property values with var(...) don't throw an error in no-invalid-properties.

What changes did you make? (Give an overview)

  • Catch var() not supported errors from CSS Tree and don't display to the user in no-invalid-properties
  • Updated documentation for no-invalid-properties
  • Added a test

Related Issues

refs #40

Is there anything you'd like reviewers to focus on?

This isn't really a fix for the issue, just suppressing the error for now. This needs to be fixed upstream in CSSTree for a better fix:
csstree/csstree#317

@mdjermanovic mdjermanovic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit f526b1d into main Jan 15, 2025
@mdjermanovic mdjermanovic deleted the property-vars branch January 15, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants