Skip to content

fix: require-baseline should not warn for cursor property#52

Merged
mdjermanovic merged 1 commit into
mainfrom
issue51
Feb 18, 2025
Merged

fix: require-baseline should not warn for cursor property#52
mdjermanovic merged 1 commit into
mainfrom
issue51

Conversation

@nzakas

@nzakas nzakas commented Feb 18, 2025

Copy link
Copy Markdown
Member

Prerequisites checklist

What is the purpose of this pull request?

Update require-baseline rule does it doesn't warn for cursor.

What changes did you make? (Give an overview)

  • Updated generate-baseline.js to not include data for cursor.
  • Added a test to the require-baseline rule to validate that cursor doesn't trigger a warning.
  • Updated the require-baseline docs to highlight that we are deviating from baseline in this case.

Related Issues

refs #51

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot Bot added the bug Something isn't working label Feb 18, 2025
@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Feb 18, 2025

@mdjermanovic mdjermanovic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 21b5aad into main Feb 18, 2025
@mdjermanovic mdjermanovic deleted the issue51 branch February 18, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants