feat: add languages and docs.dialects to rule meta types#421
Merged
lumirlumir merged 3 commits intomainfrom Apr 3, 2026
Merged
feat: add languages and docs.dialects to rule meta types#421lumirlumir merged 3 commits intomainfrom
languages and docs.dialects to rule meta types#421lumirlumir merged 3 commits intomainfrom
Conversation
mdjermanovic
reviewed
Apr 1, 2026
lumirlumir
reviewed
Apr 2, 2026
Co-authored-by: 루밀LuMir <rpfos@naver.com>
fasttime
changed the title
languages to RulesMeta interfacelanguages and docs.dialects to rule meta types
mdjermanovic
approved these changes
Apr 2, 2026
Member
mdjermanovic
left a comment
mdjermanovic
left a comment
There was a problem hiding this comment.
LGTM, thanks! Leaving open until tomorrow's release if anyone else would like to review it.
lumirlumir
approved these changes
Apr 3, 2026
Member
lumirlumir
left a comment
lumirlumir
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Since there are already two approvals, I'll go ahead and merge this PR.
github-project-automation
Bot
moved this from Second Review Needed
to Complete
in Triage
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
Update the core types.
What changes did you make? (Give an overview)
This PR adds the
languagesproperty to theRulesMetainterface (the type used for rulemetaobjects), anddialectstoRulesMetaDocs(themeta.docstype), following the design described in the rule languages RFC. The related change in ESLint has already been merged in eslint/eslint#20571. It also deprecateslanguageanddialectsinRulesMeta.Related Issues
refs eslint/eslint#19462
Is there anything you'd like reviewers to focus on?