Skip to content

Commit ca691a2

Browse files
committed
fix(esp_lvgl_port): remove IRAM_ATTR from forward declaration
Having IRAM_ATTR on both the forward declaration and the definition of lvgl_port_flush_rgb_vsync_ready_callback caused conflicting section attributes (.iram1.0 vs .iram1.1) at link time on some IDF versions. The attribute on the definition is sufficient to place the function in IRAM.
1 parent 432f11d commit ca691a2

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

components/esp_lvgl_port/src/lvgl9/esp_lvgl_port_disp.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -82,14 +82,9 @@ static lv_display_t *lvgl_port_add_disp_priv(const lvgl_port_display_cfg_t *disp
8282
static bool lvgl_port_flush_io_ready_callback(esp_lcd_panel_io_handle_t panel_io, esp_lcd_panel_io_event_data_t *edata,
8383
void *user_ctx);
8484
#if CONFIG_IDF_TARGET_ESP32S3 && ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(5, 0, 0)
85-
#if CONFIG_LCD_RGB_ISR_IRAM_SAFE
86-
static IRAM_ATTR bool lvgl_port_flush_rgb_vsync_ready_callback(esp_lcd_panel_handle_t panel_io,
87-
const esp_lcd_rgb_panel_event_data_t *edata, void *user_ctx);
88-
#else
8985
static bool lvgl_port_flush_rgb_vsync_ready_callback(esp_lcd_panel_handle_t panel_io,
9086
const esp_lcd_rgb_panel_event_data_t *edata, void *user_ctx);
9187
#endif
92-
#endif
9388
#if (CONFIG_IDF_TARGET_ESP32P4 && ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(5, 3, 0))
9489
static bool lvgl_port_flush_dpi_panel_ready_callback(esp_lcd_panel_handle_t panel_io,
9590
esp_lcd_dpi_panel_event_data_t *edata, void *user_ctx);

0 commit comments

Comments
 (0)