Remove last-child zero-margin on <dd>'s#586
Merged
choldgraf merged 1 commit intoJul 13, 2022
Merged
Conversation
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
Member
|
This looks great to me - better UI and 6 removed lines! Thanks for the improvement |
|
Congrats on your first merged pull request in this project! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there 👋
The style for dl's seems to originate from #191 and following some refactors, I don't see any changes or reasons why this margin seems so off.
I suppose it's unintentional that a definition is closer to the succeeding term than the term its actually a definition for?
Before:
After: