Skip to content

Commit 1946e0f

Browse files
authored
Remove tests accidentally added by resync (#3110)
According to the tests.toml, the removed tests reimplement tests that were once excluded. It is likely that there were accidentally added back when the tests were updated to sync back up with the problem specs. Fixes #3107
1 parent 21e60d8 commit 1946e0f

2 files changed

Lines changed: 2 additions & 23 deletions

File tree

exercises/practice/largest-series-product/.meta/tests.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ include = false
5858

5959
[6cf66098-a6af-4223-aab1-26aeeefc7402]
6060
description = "rejects empty string and nonzero span"
61+
include = false
6162
reimplements = "6d96c691-4374-4404-80ee-2ea8f3613dd4"
6263

6364
[7a38f2d6-3c35-45f6-8d6f-12e6e32d4d74]
@@ -69,4 +70,5 @@ include = false
6970

7071
[c859f34a-9bfe-4897-9c2f-6d7f8598e7f0]
7172
description = "rejects negative span"
73+
include = false
7274
reimplements = "5fe3c0e5-a945-49f2-b584-f0814b4dd1ef"

exercises/practice/largest-series-product/src/test/java/LargestSeriesProductCalculatorTest.java

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -127,17 +127,6 @@ public void testSeriesLengthLongerThanLengthOfStringToTestIsRejected() {
127127
.withMessage("Series length must be less than or equal to the length of the string to search.");
128128
}
129129

130-
@Disabled("Remove to run test")
131-
@Test
132-
@DisplayName("rejects empty string and nonzero span")
133-
public void testEmptyStringAndNonZeroSpanIsRejected() {
134-
LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator("");
135-
136-
assertThatExceptionOfType(IllegalArgumentException.class)
137-
.isThrownBy(() -> calculator.calculateLargestProductForSeriesLength(1))
138-
.withMessage("Series length must be less than or equal to the length of the string to search.");
139-
}
140-
141130
@Disabled("Remove to run test")
142131
@Test
143132
@DisplayName("rejects invalid character in digits")
@@ -147,17 +136,6 @@ public void testStringToSearchContainingNonDigitCharacterIsRejected() {
147136
.withMessage("String to search may only contain digits.");
148137
}
149138

150-
@Disabled("Remove to run test")
151-
@Test
152-
@DisplayName("rejects negative span")
153-
public void testNegativeSeriesLengthIsRejected() {
154-
LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator("12345");
155-
156-
assertThatExceptionOfType(IllegalArgumentException.class)
157-
.isThrownBy(() -> calculator.calculateLargestProductForSeriesLength(-1))
158-
.withMessage("Series length must be non-negative.");
159-
}
160-
161139
@Disabled("Remove to run test")
162140
@Test
163141
@DisplayName("integer overflow")
@@ -169,5 +147,4 @@ public void testForIntegerOverflow() {
169147

170148
assertThat(actualProduct).isEqualTo(expectedProduct);
171149
}
172-
173150
}

0 commit comments

Comments
 (0)