Fix glossary entry proposal command signatures

- Update Approve and Reject commands to accept proposal directly instead of glossary_entry
- Fix controller to pass @proposal to Approve/Reject commands
- Update test expectations to match corrected command signatures
- Resolves logical inconsistency where commands tried to find proposals through glossary entries

Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-b0f4fc46-b5d8-47f8-899f-b9cab8f38b5f

Author: iHiD

app/commands/localization/glossary_entry_proposal/approve.rb

@@ -1,7 +1,7 @@
 class Localization::GlossaryEntryProposal::Approve
   include Mandate
 
-  initialize_with :glossary_entry, :user
+  initialize_with :proposal, :user
 
   def call
     ActiveRecord::Base.transaction do
@@ -30,16 +30,16 @@ def handle_addition!
   end
 
   def handle_modification!
-    raise "No glossary entry to modify" if glossary_entry.nil?
+    raise "No glossary entry to modify" if proposal.glossary_entry.nil?
 
-    glossary_entry.update!(
+    proposal.glossary_entry.update!(
       translation: proposal.translation,
       llm_instructions: proposal.llm_instructions
     )
   end
 
   def handle_deletion!
-    raise "No glossary entry to delete" if glossary_entry.nil?
+    raise "No glossary entry to delete" if proposal.glossary_entry.nil?
 
     # Retrieve this before destroying else we have a race
     glossary_entry = proposal.glossary_entry
@@ -48,9 +48,4 @@ def handle_deletion!
     proposal.update!(glossary_entry: nil)
     glossary_entry.destroy!
   end
-
-  memoize
-  def proposal
-    glossary_entry.proposals.pending.first
-  end
 end

app/commands/localization/glossary_entry_proposal/reject.rb

@@ -1,7 +1,7 @@
 class Localization::GlossaryEntryProposal::Reject
   include Mandate
 
-  initialize_with :glossary_entry, :user
+  initialize_with :proposal, :user
 
   def call
     ActiveRecord::Base.transaction do
@@ -11,9 +11,4 @@ def call
       )
     end
   end
-
-  memoize
-  def proposal
-    glossary_entry.proposals.pending.first
-  end
 end

app/controllers/api/localization/glossary_entry_proposals_controller.rb

@@ -11,15 +11,15 @@ def create
   end
 
   def approve
-    Localization::GlossaryEntryProposal::Approve.(@glossary_entry, current_user)
+    Localization::GlossaryEntryProposal::Approve.(@proposal, current_user)
 
     render json: {
       glossary_entry: SerializeLocalizationGlossaryEntry.(@glossary_entry, current_user)
     }
   end
 
   def reject
-    Localization::GlossaryEntryProposal::Reject.(@glossary_entry, current_user)
+    Localization::GlossaryEntryProposal::Reject.(@proposal, current_user)
 
     render json: {
       glossary_entry: SerializeLocalizationGlossaryEntry.(@glossary_entry, current_user)

test/controllers/api/localization/glossary_entries_proposals_controller_test.rb

@@ -22,7 +22,7 @@ class API::Localization::GlossaryEntriesProposalsControllerTest < API::BaseTestC
     glossary_entry = create :localization_glossary_entry
     proposal = create :localization_glossary_entry_proposal, :modification, glossary_entry: glossary_entry, proposer: @current_user
 
-    Localization::GlossaryEntryProposal::Approve.expects(:call).with(glossary_entry, @current_user)
+    Localization::GlossaryEntryProposal::Approve.expects(:call).with(proposal, @current_user)
 
     patch approve_api_localization_glossary_entry_proposal_path(glossary_entry, proposal), headers: @headers, as: :json
 
@@ -36,7 +36,7 @@ class API::Localization::GlossaryEntriesProposalsControllerTest < API::BaseTestC
     glossary_entry = create :localization_glossary_entry
     proposal = create :localization_glossary_entry_proposal, :modification, glossary_entry: glossary_entry, proposer: @current_user
 
-    Localization::GlossaryEntryProposal::Reject.expects(:call).with(glossary_entry, @current_user)
+    Localization::GlossaryEntryProposal::Reject.expects(:call).with(proposal, @current_user)
 
     patch reject_api_localization_glossary_entry_proposal_path(glossary_entry, proposal), headers: @headers, as: :json