Replace billing email heuristic with checkout session check (#8337)

* Fix Stripe reconciliation: status is not a valid list filter

PaymentIntent.list doesn't accept a status parameter. Filter
client-side instead.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Replace billing email heuristic with checkout session check

The bootcamp payment filter used billing_details.email presence to
distinguish bootcamp payments from donations. This was wrong - some
donors have billing emails too, causing their payments to be silently
dropped. Bootcamp payments were created via Checkout Sessions while
donations are not, so use that as the heuristic instead.

Also removes the invalid status parameter from PaymentIntent.list
in the reconciliation command.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: iHiD

app/commands/payments/stripe/payment_intent/handle_success.rb

@@ -40,12 +40,8 @@ def subscription_data
   def should_record_payment?
     return true if subscription_data
 
-    charge = Stripe::Charge.retrieve(payment_intent.latest_charge)
-
-    # If there is an email, then it's the Bootcamp.
-    # If there's not an email, then through our integration.
-    # This is terrible, I know.
-    charge.billing_details.email.blank?
+    # Bootcamp payments were created via Checkout Sessions; donations are not.
+    Stripe::Checkout::Session.list({ payment_intent: payment_intent.id }).data.empty?
   rescue StandardError
     true
   end

app/commands/payments/stripe/reconcile_payments.rb

@@ -41,8 +41,8 @@ def sync_payment_intent(payment_intent)
   def should_record_payment?(payment_intent)
     return true if payment_intent.invoice
 
-    charge = payment_intent.latest_charge
-    charge&.billing_details&.email.blank?
+    # Bootcamp payments were created via Checkout Sessions; donations are not.
+    Stripe::Checkout::Session.list({ payment_intent: payment_intent.id }).data.empty?
   rescue StandardError
     true
   end

test/commands/payments/stripe/reconcile_payments_test.rb

@@ -39,14 +39,14 @@ class Payments::Stripe::ReconcilePaymentsTest < Payments::TestBase
     end
   end
 
-  test "skips bootcamp payments with billing email" do
+  test "skips bootcamp payments with checkout session" do
     freeze_time do
       create :user, stripe_customer_id: "cus_123"
       since = 90.days.ago
 
-      pis = [build_payment_intent("pi_bootcamp", customer: "cus_123",
-        amount: 4900, billing_email: "buyer@example.com")]
+      pis = [build_payment_intent("pi_bootcamp", customer: "cus_123", amount: 4900)]
       stub_payment_intents_list(pis, created_gte: since.to_i)
+      stub_checkout_session("pi_bootcamp", exists: true)
 
       Payments::Stripe::ReconcilePayments.(since:)
 
@@ -151,23 +151,14 @@ class Payments::Stripe::ReconcilePaymentsTest < Payments::TestBase
     end
   end
 
-  test "records subscription payment even with billing email" do
+  test "records donation with billing email but no checkout session" do
     freeze_time do
-      user = create :user, stripe_customer_id: "cus_123"
-      create :payments_subscription, user: user, external_id: "sub_abc", provider: :stripe
-      invoice_id = "in_sub_email"
+      create :user, stripe_customer_id: "cus_123"
       since = 90.days.ago
 
-      pis = [build_payment_intent("pi_sub_email", customer: "cus_123", amount: 999,
-        billing_email: "someone@example.com", invoice: invoice_id)]
+      pis = [build_payment_intent("pi_email_donor", customer: "cus_123", amount: 1500)]
       stub_payment_intents_list(pis, created_gte: since.to_i)
-
-      stub_request(:get, "https://api.stripe.com/v1/invoices/#{invoice_id}").
-        to_return(
-          status: 200,
-          body: { id: invoice_id, object: "invoice", subscription: "sub_abc" }.to_json,
-          headers: { 'Content-Type': 'application/json' }
-        )
+      stub_checkout_session("pi_email_donor", exists: false)
 
       Payments::Stripe::ReconcilePayments.(since:)
 
@@ -242,8 +233,20 @@ def stub_payment_intents_request(body:, created_gte:, starting_after: nil)
       )
   end
 
+  def stub_checkout_session(payment_intent_id, exists:)
+    data = exists ? [{ id: "cs_#{SecureRandom.hex(8)}", object: "checkout.session" }] : []
+    stub_request(:get, "https://api.stripe.com/v1/checkout/sessions?payment_intent=#{payment_intent_id}").
+      to_return(
+        status: 200,
+        body: { object: "list", data:, has_more: false, url: "/v1/checkout/sessions" }.to_json,
+        headers: { 'Content-Type': 'application/json' }
+      )
+  end
+
   def build_payment_intent(id, customer:, amount:, receipt_url: nil,
-                           billing_email: nil, invoice: nil, created: Time.current.to_i)
+                           invoice: nil, created: Time.current.to_i)
+    stub_checkout_session(id, exists: false)
+
     {
       id:,
       object: "payment_intent",
@@ -255,10 +258,7 @@ def build_payment_intent(id, customer:, amount:, receipt_url: nil,
       latest_charge: {
         id: "ch_#{SecureRandom.hex(8)}",
         object: "charge",
-        receipt_url:,
-        billing_details: {
-          email: billing_email
-        }
+        receipt_url:
       }
     }
   end