Skip to content

Commit 8cd2430

Browse files
authored
show tweaks (#8212)
* Add back RHS, tweak LLM instructions visually * More copy and visual tweaks
1 parent 9535757 commit 8cd2430

2 files changed

Lines changed: 49 additions & 11 deletions

File tree

  • app
    • css/pages/localization
    • javascript/components/localization/glossary-entries/show

app/css/pages/localization/show.css

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ body.namespace-localization.controller-glossary_entries.action-show {
4040
.body-container {
4141
@apply flex flex-1;
4242
@apply bg-backgroundColorA;
43+
@apply h-screen;
4344
}
4445

4546
.lhs {
@@ -63,12 +64,12 @@ body.namespace-localization.controller-glossary_entries.action-show {
6364
}
6465
.original {
6566
p {
66-
@apply text-16 leading-140 mb-8;
67+
@apply text-16 leading-160 mb-16;
6768
}
6869
}
6970

7071
.translations {
71-
@apply mb-16;
72+
@apply mb-16 mr-16;
7273
.locale {
7374
&.unchecked {
7475
--locale-background-color: #ffeeee;

app/javascript/components/localization/glossary-entries/show/index.tsx

Lines changed: 46 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ function Header() {
3737
<Icon icon="close" className="c-icon" alt="Close" />
3838
</a>
3939
<div className="info">
40-
<div className="intro">You are editing glossary entry for</div>
40+
<div className="intro">You are editing the glossary entry for</div>
4141
<div className="key">
4242
{glossaryEntry.term} ({glossaryEntry.locale})
4343
</div>
@@ -51,33 +51,70 @@ function Body() {
5151
return (
5252
<div className="lg-container body-container">
5353
<LHS />
54+
<RHS />
5455
</div>
5556
)
5657
}
5758

5859
function LHS() {
59-
const { glossaryEntry, currentUserId, links } = React.useContext(
60+
const { glossaryEntry, currentUserId } = React.useContext(
6061
GlossaryEntriesShowContext
6162
)
6263

6364
useLogger('render', glossaryEntry)
6465
return (
6566
<div className="translations mt-16 max-w-[800px]">
66-
<h2 className="text-h2 mb-4">Proposals</h2>
67+
<h2 className="text-h2 mb-4">Proposal</h2>
6768
<p className="text-p-base mb-16">
68-
These are the proposals suggested by either an LLM or other translators.
69-
Each proposal must be checked and then signed-off. Please{' '}
69+
This proposal was suggested by an LLM or another translator. It needs to
70+
be reviewed and signed off. Please{' '}
7071
<strong className="font-semibold">
71-
edit translations that are incorrect
72-
</strong>
73-
, which will put them in a queue for other reviewers to see, or mark
74-
them as checked/signed-off.
72+
edit any incorrect translations.
73+
</strong>{' '}
74+
Your changes will be placed in a queue for another reviewer, or mark it
75+
as checked and signed off.
7576
</p>
7677
{renderShow(glossaryEntry, currentUserId)}
7778
</div>
7879
)
7980
}
8081

82+
function RHS() {
83+
const { glossaryEntry } = React.useContext(GlossaryEntriesShowContext)
84+
return (
85+
<div className="rhs">
86+
<div className="original">
87+
<h2 className="text-h3 mb-6">The Entry</h2>
88+
<p>
89+
Your job is to make the translation as close to the original English
90+
in <strong className="font-semibold">meaning and tone</strong> as
91+
possible, considering how it is used on the site.
92+
</p>
93+
<p>
94+
<strong className="font-semibold">
95+
Please be careful not to change the meaning of the original English
96+
</strong>
97+
. If you believe the original English is wrong, please{' '}
98+
<a
99+
href="https://forum.exercism.org/c/exercism/i18n/695"
100+
className="c-prominent-link --inline"
101+
>
102+
start a discussion on the forum
103+
</a>
104+
.
105+
</p>
106+
107+
<div className="c-textblock-note">
108+
<div className="c-textblock-header">How this term is used</div>
109+
<div className="c-textblock-content">
110+
<p>{glossaryEntry.llmInstructions}</p>
111+
</div>
112+
</div>
113+
</div>
114+
</div>
115+
)
116+
}
117+
81118
function renderShow(
82119
glossaryEntry: GlossaryEntry,
83120
currentUserId: string | number

0 commit comments

Comments
 (0)