[eas-cli] Deprecate isGlobal GraphQL input property of environment variables (#3190)

<!-- If this PR requires a changelog entry, add it by commenting the PR with the command `/changelog-entry [breaking-change|new-feature|bug-fix|chore] [message]`. -->
<!-- You can skip the changelog check by labeling the PR with "no changelog". -->

# Why

See expo/universe#22108.

# How

- Updated GraphQL code.
- Adjusted code to the updated GraphQL code (no `isGlobal`).
- Updated types in `EnvironmentVariableMutation` so they don't re-implement what GraphQL is generating for us.
- Updated types in `env:push`.

# Test Plan

Adjusted tests.

Author: sjchmiela

packages/eas-cli/graphql.schema.json

@@ -47,6 +47,7 @@ describe(EnvCreate, () => {
         createdAt: new Date().toISOString(),
         updatedAt: new Date().toISOString(),
         scope: EnvironmentVariableScope.Project,
+        type: EnvironmentSecretType.String,
       }));
     jest
       .mocked(EnvironmentVariableMutation.createSharedVariableAsync)
@@ -56,6 +57,7 @@ describe(EnvCreate, () => {
         createdAt: new Date().toISOString(),
         updatedAt: new Date().toISOString(),
         scope: EnvironmentVariableScope.Shared,
+        type: EnvironmentSecretType.String,
       }));
     jest
       .mocked(EnvironmentVariableMutation.updateAsync)
@@ -199,7 +201,6 @@ describe(EnvCreate, () => {
         {
           name: 'VarName',
           value: 'VarValue',
-          isGlobal: true,
           environments: [EnvironmentVariableEnvironment.Production],
           visibility: EnvironmentVariableVisibility.Public,
           type: EnvironmentSecretType.String,
@@ -324,7 +325,6 @@ describe(EnvCreate, () => {
             EnvironmentVariableEnvironment.Development,
           ],
           visibility: EnvironmentVariableVisibility.Public,
-          isGlobal: true,
           type: EnvironmentSecretType.String,
         },
         testAccountId

packages/eas-cli/src/commands/env/__tests__/EnvCreate.test.ts

@@ -220,7 +220,6 @@ export default class EnvCreate extends EasCommand {
                 value,
                 visibility,
                 environments,
-                isGlobal: true, // TODO: every account-wide variable is global for now so it's not user facing
                 type: type ?? EnvironmentSecretType.String,
               },
               ownerAccount.id

packages/eas-cli/src/commands/env/create.ts

@@ -6,15 +6,13 @@ import path from 'path';
 import EasCommand from '../../commandUtils/EasCommand';
 import { EASMultiEnvironmentFlag } from '../../commandUtils/flags';
 import {
+  CreateEnvironmentVariableInput,
   EnvironmentVariableEnvironment,
   EnvironmentVariableFragment,
   EnvironmentVariableScope,
   EnvironmentVariableVisibility,
 } from '../../graphql/generated';
-import {
-  EnvironmentVariableMutation,
-  EnvironmentVariablePushInput,
-} from '../../graphql/mutations/EnvironmentVariableMutation';
+import { EnvironmentVariableMutation } from '../../graphql/mutations/EnvironmentVariableMutation';
 import { EnvironmentVariablesQuery } from '../../graphql/queries/EnvironmentVariablesQuery';
 import Log from '../../log';
 import { confirmAsync, promptAsync } from '../../prompts';
@@ -66,8 +64,7 @@ export default class EnvPush extends EasCommand {
       });
     }
 
-    const updateVariables: Record<string, EnvironmentVariablePushInput> =
-      await this.parseEnvFileAsync(envPath, environments);
+    const updateVariables = await this.parseEnvFileAsync(envPath, environments);
 
     const variableNames = Object.keys(updateVariables);
 
@@ -219,11 +216,16 @@ export default class EnvPush extends EasCommand {
   private async parseEnvFileAsync(
     envPath: string,
     environments: EnvironmentVariableEnvironment[]
-  ): Promise<Record<string, EnvironmentVariablePushInput>> {
+  ): Promise<
+    Record<
+      string,
+      CreateEnvironmentVariableInput & { environments: EnvironmentVariableEnvironment[] }
+    >
+  > {
     if (!(await fs.exists(envPath))) {
       throw new Error(`File ${envPath} does not exist.`);
     }
-    const pushInput: Record<string, EnvironmentVariablePushInput> = {};
+    const pushInput: Awaited<ReturnType<typeof this.parseEnvFileAsync>> = {};
 
     const variables: Record<string, string> = dotenv.parse(await fs.readFile(envPath, 'utf8'));
 

packages/eas-cli/src/commands/env/push.ts

@@ -7,37 +7,19 @@ import {
   CreateBulkEnvironmentVariablesForAppMutation,
   CreateEnvironmentVariableForAccountMutation,
   CreateEnvironmentVariableForAppMutation,
+  CreateEnvironmentVariableInput,
+  CreateSharedEnvironmentVariableInput,
   DeleteEnvironmentVariableMutation,
-  EnvironmentSecretType,
-  EnvironmentVariableEnvironment,
   EnvironmentVariableFragment,
-  EnvironmentVariableVisibility,
+  UpdateEnvironmentVariableInput,
   UpdateEnvironmentVariableMutation,
 } from '../generated';
 import { EnvironmentVariableFragmentNode } from '../types/EnvironmentVariable';
 
-type CreateVariableArgs = {
-  value: string;
-  name: string;
-  visibility: EnvironmentVariableVisibility;
-  environments: EnvironmentVariableEnvironment[];
-  type: EnvironmentSecretType;
-  isGlobal?: boolean;
-  fileName?: string;
-};
-
-export type EnvironmentVariablePushInput = {
-  name: string;
-  value: string;
-  environments: EnvironmentVariableEnvironment[];
-  visibility: EnvironmentVariableVisibility;
-  overwrite?: boolean;
-};
-
 export const EnvironmentVariableMutation = {
   async createSharedVariableAsync(
     graphqlClient: ExpoGraphqlClient,
-    input: CreateVariableArgs,
+    input: CreateSharedEnvironmentVariableInput,
     accountId: string
   ): Promise<EnvironmentVariableFragment> {
     const data = await withErrorHandlingAsync(
@@ -69,7 +51,7 @@ export const EnvironmentVariableMutation = {
   },
   async createForAppAsync(
     graphqlClient: ExpoGraphqlClient,
-    input: CreateVariableArgs,
+    input: CreateEnvironmentVariableInput,
     appId: string
   ): Promise<EnvironmentVariableFragment> {
     const data = await withErrorHandlingAsync(
@@ -98,7 +80,7 @@ export const EnvironmentVariableMutation = {
   },
   async updateAsync(
     graphqlClient: ExpoGraphqlClient,
-    input: Partial<CreateVariableArgs> & { id: string }
+    input: UpdateEnvironmentVariableInput
   ): Promise<EnvironmentVariableFragment> {
     const data = await withErrorHandlingAsync(
       graphqlClient
@@ -143,7 +125,7 @@ export const EnvironmentVariableMutation = {
   },
   async createBulkEnvironmentVariablesForAppAsync(
     graphqlClient: ExpoGraphqlClient,
-    input: EnvironmentVariablePushInput[],
+    input: CreateEnvironmentVariableInput[],
     appId: string
   ): Promise<boolean> {
     await withErrorHandlingAsync(