Skip to content

Commit f4fc39a

Browse files
committed
refactor: remove third party notice until its updated
1 parent a019c94 commit f4fc39a

3 files changed

Lines changed: 5 additions & 2311 deletions

File tree

base/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ RUN npm install --global expo-cli@2 \
1010
&& npm cache rm --force \
1111
&& rm -rf ~/.npm
1212

13-
COPY LICENSE.md README.md THIRD_PARTY_NOTICE.md /
13+
COPY LICENSE.md README.md /
1414
COPY entrypoint.sh /entrypoint.sh
1515

1616
ENTRYPOINT ["/entrypoint.sh"]

base/README.md

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,17 @@
33
A prebuilt docker image to use the [Expo CLI](https://docs.expo.io/versions/latest/workflow/expo-cli) on Docker-based environments.
44
This image contains all necessary libraries to perform all commands of the CLI.
55

6-
- Based on `node:10-alpine` image
6+
- Based on `node:10` image
77
- Contains globally installed `expo-cli@2`
8-
- Contains `bash` for [Metro bundler](https://facebook.github.io/metro/)
9-
- Contains `git` for NPM repository references
108

119
## Usage
1210

1311
The entry point of this image forwards to the Expo CLI itself.
14-
With this entry point you can provide any command directly to Docker.
12+
With this entry point, you can provide any command directly to Docker.
1513
When nothing is provided, it will output the help information provided by the CLI.
1614

15+
> The entry point uses `sh -c` to invoke Expo, making environment variable available to that command.
16+
1717
```bash
1818
$ docker run --rm bycedric/ci-expo
1919
$ docker run --rm bycedric/ci-expo pubish
@@ -27,8 +27,6 @@ $ docker run --rm -ti --entrypoint sh bycedric/ci-expo
2727

2828
The MIT License (MIT). Please see [License File](LICENSE.md) for more information.
2929

30-
> This image is built on top of awesome open source libraries, see [third party licenses](THIRD_PARTY_NOTICE.md) for more information.
31-
3230
--- ---
3331

3432
<p align="center">

0 commit comments

Comments
 (0)