feat: added projectDeepLink to template variables#165
Conversation
byCedric
left a comment
byCedric
left a comment
There was a problem hiding this comment.
Great idea! Left a comment related to the URL and a test.
I'm also a bit mixed about the DeepLink naming, technically we have two types of deeplinks. Right now, we only support Expo Go/managed links but we definitely want to support dev client links. For now, I think this is ok, since it depends on the project structure itself (which we can detect). But maybe you have some thoughts on that? 😄
|
Also, quick sidenote, the failing CI tests can be ignored. If you rebase on main, they should not fail again. |
giautm
force-pushed
the
project-deep-link
branch
from
60039b3 to
1534d58
Compare
giautm
force-pushed
the
project-deep-link
branch
from
1534d58 to
44a8698
Compare
|
Hey @byCedric, can you approve the workflow again for testing. Thank you. ❤️ |
|
Hmm, seems like I messed up some of the workflow conditions. Let's leave CI for what it is and just merge it! 😄 |
|
Thanks, I'll release it tomorrow |
## [7.1.0](7.0.3...7.1.0) (2022-03-04) ### New features * add projectDeepLink to template variables ([#165](#165)) ([2603f85](2603f85)) ### Other chores * run authed tests only when auth is available ([5815161](5815161)) * set major tag version to release commit ([b516013](b516013)) * skip steps if auth is unavailable ([bb7c723](bb7c723)) * update github action author name ([#166](#166)) ([520d959](520d959))
|
🎉 This PR is included in version 7.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
2 participants
This PR added a new variable:
projectDeepLinkto support open Expo Go when the user using the Github Mobile app.