feature: add readme for preview-build and fingerprint action#232
Merged
Conversation
byCedric
reviewed
Sep 20, 2023
Member
byCedric
left a comment
byCedric
left a comment
There was a problem hiding this comment.
Looking good, thanks for adding these. Created a few comments with suggestions 😄
| permissions: | ||
| # REQUIRED: Allow comments of PRs | ||
| pull-requests: write # Allow comments on PRs | ||
| # REQUIRED: Allow updating fingerprint in acton caches |
Member
There was a problem hiding this comment.
Thanks for being explicit in these # REQUIRED parts 😄
| - uses: actions/github-script@v6 | ||
| if: ${{ github.event_name == 'pull_request' && github.steps.fingerprint.outputs.fingerprint-diff == '[]' }} | ||
| with: | ||
| script: | |
Member
There was a problem hiding this comment.
Would be awesome if we could add a script for users to reuse since it might clutter their workflow a bit.
For now, I think it's fine.
byCedric
reviewed
Sep 20, 2023
byCedric
reviewed
Sep 20, 2023
byCedric
reviewed
Sep 20, 2023
byCedric
reviewed
Sep 20, 2023
Co-authored-by: Cedric van Putten <me@bycedric.com>
expo-bot
pushed a commit
that referenced
this pull request
Nov 24, 2023
## [8.1.0](8.0.0...8.1.0) (2023-11-24) ### New features * add fingerprint integration ([#231](#231)) ([e6622e0](e6622e0)) * add readme for preview-build and fingerprint action ([#232](#232)) ([acc171b](acc171b)), closes [/github.com//pull/231#pullrequestreview-1628540314](https://github.com/expo//github.com/expo/expo-github-action/pull/231/issues/pullrequestreview-1628540314) * **preview:** add update manifest permalinks to the output ([#245](#245)) ([331a5ab](331a5ab)) ### Bug fixes * **preview:** allow multiple `app.json` schemes ([#244](#244)) ([42d64cf](42d64cf)) ### Code changes * update error handling to node 20 standards ([#243](#243)) ([65ee055](65ee055)) * update workflows and repository to use Bun ([#241](#241)) ([7f1c170](7f1c170)) * upgrade all actions to run on node 20 ([#242](#242)) ([b3e5355](b3e5355)) ### Other chores * **ci:** update release flow with new service account ([#238](#238)) ([e289d93](e289d93)) * update release workflow actions ([#239](#239)) ([57dcabe](57dcabe)) ### Documentation changes * add link to breaking change pull request ([9e1a8c8](9e1a8c8)) * fix changelog link in readme ([185932d](185932d)) * update example to use `eas-version` ([#222](#222)) ([7bc946c](7bc946c))
|
🎉 This PR is included in version 8.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
following up with #231 (review) to add READMEs