Conversation
b9aea5f to
3d01cb4
Compare
BREAKING CHANGE: Github Action inputs are changed to allow both Expo and EAS CLI.
jonsamp
approved these changes
Jun 22, 2021
Member
jonsamp
left a comment
There was a problem hiding this comment.
I'm not familiar enough with the code to give you code-level review, but I tried this out in a project of mine and it worked well!
Here's my action for reference:
name: update
on:
push:
branches: [main]
jobs:
update:
name: Install and update
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 15.x
- uses: expo/expo-github-action@eas-support
with:
expo-version: latest
eas-version: latest
token: ${{ secrets.EXPO_TOKEN }}
expo-cache: true
eas-cache: true
- name: Find cache
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"
- name: Restore cache
uses: actions/cache@v2
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn-
- run: yarn install
- run: eas branch:publish $(echo ${{ github.ref }} | sed 's_refs/heads/__') --message "${{ github.event.head_commit.message }}"
Member
Author
|
Nice, thanks for testing it! We should probably add some output helpers to get you of that ugly Also, random sidenote, I would stick with the even-numbered node versions. The uneven are more like experiments and will be EOL soon see releases |
byCedric
added a commit
that referenced
this pull request
Jun 22, 2021
* feature!: add support for eas cli installs * refactor: update the action metadata * docs: update documentation to include eas examples * fix: breaking change detection for semantic release * docs: add notion about latest eas version BREAKING CHANGE: Github Action inputs are changed to allow both Expo and EAS CLI.
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 22, 2021
## [6.0.0](5.5.1...6.0.0) (2021-06-22) ### ⚠ BREAKING CHANGES * Github Action inputs are changed to allow both Expo and EAS CLI. ### New features * add support for eas cli installs ([#98](#98)) ([04692c3](04692c3)) ### Other chores * update node to 14 and 16 in ci ([#100](#100)) ([a03876e](a03876e)) ### Documentation changes * add commands to contirbuting guide for updating v{major} tags ([1b57c37](1b57c37)) * update readme for v6 release ([#101](#101)) ([8b43bae](8b43bae)) * update upstream reference in contributing guide ([76ce4de](76ce4de))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Github Action inputs are changed to allow both Expo and EAS CLI.
Part of #97