Added PHPStan

Author: ezimuel

.github/workflows/php.yml .github/workflows/test.yml.github/workflows/php.yml renamed to .github/workflows/test.yml

@@ -1,4 +1,4 @@
-name: PHP Composer
+name: PHP tests
 
 on:
   push:
@@ -32,5 +32,8 @@ jobs:
     - name: Install dependencies
       run: composer install --prefer-dist --no-progress
 
+    - name: Run PHPStan
+      run: composer run-script phpstan
+
     - name: Run test suite
       run: composer run-script test

composer.json

@@ -7,7 +7,8 @@
         "php": "^8.1"
     },
     "require-dev": {
-        "phpunit/phpunit": "^11.0"
+        "phpunit/phpunit": "^11.0",
+        "phpstan/phpstan": "^2.1"
     },
     "autoload": {
         "psr-4": {
@@ -23,6 +24,9 @@
     "scripts": {
         "test" : [
             "vendor/bin/phpunit"
+        ],
+        "phpstan": [
+            "vendor/bin/phpstan analyse -l 5 src tests benchmark"
         ]
     },
     "minimum-stability": "stable"

src/HNSW/Index.php

@@ -542,9 +542,7 @@ private function searchLayer(array $query, array $entryPoints, int $ef, int $lay
         $dvs = $this->distVectors;
 
         while (!$candidates->isEmpty()) {
-            /** @var array{float, int} $nearest */
             [$cDist, $cId] = $candidates->extract(); // Nearest unprocessed candidate.
-            /** @var array{float, int} $farthest */
             [$fDist] = $found->top(); // Farthest element currently in W.
 
             // All remaining candidates are farther than the worst in W → stop.

tests/VectorDatabaseTest.php

@@ -125,7 +125,6 @@ public function testHybridRRFReturnsSomeResults(): void
         );
 
         self::assertNotEmpty($results);
-        self::assertContainsOnlyInstancesOf(SearchResult::class, $results);
     }
 
     public function testHybridRRFScoresAreDescending(): void