Skip to content

Commit c513d29

Browse files
committed
Fix linting issues: remove unused imports and trailing whitespace
- Remove unused 'import ghstack.merge_rules' from dry_run.py.test and validate_rules_pass.py.test (F401) - Fix trailing whitespace on blank lines (W293)
1 parent 7daeee9 commit c513d29

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

test/land/dry_run.py.test

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ from ghstack.test_prelude import *
22

33
import os
44
import tempfile
5-
import ghstack.merge_rules
65
from ghstack.github_fake import GitHubNumber, PullRequestReview, CheckRun
76

87
init_test()
@@ -33,14 +32,14 @@ with tempfile.NamedTemporaryFile(mode="w", suffix=".yaml", delete=False) as f:
3332
try:
3433
# Get the initial state of master
3534
initial_log = get_upstream_sh().git("log", "--oneline", "master")
36-
35+
3736
# Dry run should NOT land the commit
3837
gh_land(pr_url, validate_rules=True, dry_run=True, rules_file=rules_file)
39-
38+
4039
# Verify master is unchanged (no commit was landed)
4140
final_log = get_upstream_sh().git("log", "--oneline", "master")
4241
assert_eq(initial_log, final_log)
43-
42+
4443
# The PR should still be open
4544
assert_eq(pr.closed, False)
4645
finally:

test/land/validate_rules_pass.py.test

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ from ghstack.test_prelude import *
22

33
import os
44
import tempfile
5-
import ghstack.merge_rules
65
from ghstack.github_fake import GitHubNumber, PullRequestReview, CheckRun
76

87
init_test()
@@ -33,7 +32,7 @@ with tempfile.NamedTemporaryFile(mode="w", suffix=".yaml", delete=False) as f:
3332
try:
3433
# Land with validation - should succeed
3534
gh_land(pr_url, validate_rules=True, rules_file=rules_file)
36-
35+
3736
# Verify the commit was landed
3837
assert_expected_inline(
3938
get_upstream_sh().git("log", "--oneline", "master"),

0 commit comments

Comments
 (0)