Don't use "dst" literal as sni name on https backends with host=dst is set (#917)

nathanejohnson · web-flow · commit d76b4acf7c5e · 2022-12-07T17:06:58.000-06:00
Fixes #916
diff --git a/route/route.go b/route/route.go
@@ -75,7 +75,9 @@ func (r *Route) addTarget(service string, targetURL *url.URL, fixedWeight float6
 		t.Host = opts["host"]
 		t.ProxyProto = opts["pxyproto"] == "true"
 
-		if t.Host != "" && (t.URL.Scheme == "https" || opts["proto"] == "https") {
+		// if Host is "dst", we don't need a special transport to override the sni because
+		// this is already the default behavior.
+		if t.Host != "" && t.Host != "dst" && (t.URL.Scheme == "https" || opts["proto"] == "https") {
 			t.Transport = transport.NewTransport(&tls.Config{ServerName: t.Host, InsecureSkipVerify: t.TLSSkipVerify})
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,9 @@ func (r Route) addTarget(service string, targetURL url.URL, fixedWeight float6`
`75`	`75`	`t.Host = opts["host"]`
`76`	`76`	`t.ProxyProto = opts["pxyproto"] == "true"`
`77`	`77`
`78`		`- if t.Host != "" && (t.URL.Scheme == "https" \|\| opts["proto"] == "https") {`
	`78`	`+ // if Host is "dst", we don't need a special transport to override the sni because`
	`79`	`+ // this is already the default behavior.`
	`80`	`+ if t.Host != "" && t.Host != "dst" && (t.URL.Scheme == "https" \|\| opts["proto"] == "https") {`
`79`	`81`	`t.Transport = transport.NewTransport(&tls.Config{ServerName: t.Host, InsecureSkipVerify: t.TLSSkipVerify})`
`80`	`82`	`}`
`81`	`83`