Skip to content

Commit 30a62c1

Browse files
Re-sync with internal repository (#23)
The internal and external repositories are out of sync. This Pull Request attempts to brings them back in sync by patching the GitHub repository. Please carefully review this patch. You must disable ShipIt for your project in order to merge this pull request. DO NOT IMPORT this pull request. Instead, merge it directly on GitHub using the MERGE BUTTON. Re-enable ShipIt after merging. fbshipit-source-id: 2471175e381e86fa65da03de08bb883c416ad0e1 Co-authored-by: Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
1 parent 0f031d0 commit 30a62c1

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

taac/testconfigs/routing/ebb/bag013_ash6_test_config.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
from neteng.test_infra.dne.taac.constants import BgpPlusPlusProfile, Gigabyte
2424
from taac.health_checks.healthcheck_definitions import (
2525
create_bgp_session_establish_check,
26+
create_bgp_update_group_check,
2627
create_cpu_utilization_check,
2728
create_drain_state_check,
2829
create_memory_utilization_check,
@@ -239,6 +240,14 @@ def _bag013_2_7_2_prechecks():
239240
create_cpu_utilization_check(
240241
threshold=400.0, start_time_jq_var="test_case_start_time"
241242
),
243+
# Confirm BGP++ ``update_group`` is actually active on the running
244+
# daemon before the flap loop starts. Mirrors the setup-task-level
245+
# ``Cli -p15 -c 'show bgpcpp update-group'`` guard in
246+
# ``conveyor_common_tasks._get_control_plane_tasks`` (D108374944), but
247+
# goes through the ``getUpdateGroupInfo`` thrift API (D108632994)
248+
# instead of CLI parsing. Provides a second, structured early-fail if
249+
# the patch silently regressed between setup completion and prechecks.
250+
create_bgp_update_group_check(expect_enabled=True),
242251
]
243252

244253

0 commit comments

Comments
 (0)