Rebase sidewalk_v1_preview onto main (#276)

* Move CrossEditableZoom event firing.
It should happen after projection is transformed.

* Bump versions

* Switch to Mapillary API v4

* Fix traffic sign rendering and geometry conversion

* Remove debugging code

* Update locale file

* Removing redundant @mapbox/geojson-rewind dep pkg

* Remove unused map feature title

* Bring map map feature tooltips

* Add missing mapillary map feature classes

* Update translation file

* Bing imagery - Ensure freshness

* bingImagery strict n param.
Fallback url tempalate to latest

* minor revert catch log

* some bing imagery docs comments

* typo

* Add aws_deploy npm action to build workflow (#229)

* Add aws_deploy npm action to build workflow

Added the scripts/aws_deploy.py script which will run at the end of
github builds and push stuff up to s3, so that you can easily get builds
to reviewers or anyone else without issue.

Needs to have some secrets set up on github to work, documentation is at
the top of the python script.

* Hopefully more verbose logging when amazon fails

* DO NOT MERGE: Adding hook for this branch to test on github

* Better capture failure cases of aws calls

* Going with the middle spam level for logging

* Replace Rollup with Esbuild. (#246)

* Add new esbuild-based quickstart directive.

* Get the esbuild legacy build working, save for issues with NSI.

* Upgrade several dependencies, bump minimum node version to 12
- country-coder (closes #249)
- location-conflation (closes #248)
- osm-community-index (closes #250)
- name-suggestion-index

* Bump marked from 2.0.7 to 2.1.2

Bumps [marked](https://github.com/markedjs/marked) from 2.0.7 to 2.1.2.
- [Release notes](https://github.com/markedjs/marked/releases)
- [Changelog](https://github.com/markedjs/marked/blob/master/release.config.js)
- [Commits](markedjs/marked@v2.0.7...v2.1.2)

---
updated-dependencies:
- dependency-name: marked
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Add the es5 directive back.

* Get dev builds working once again, normal builds still slightly wonky.

* Get some sort of legacy build working by converting requires() to import statements.

* Fix target for esbuild legacy build

* Move build all directive to use esbuild.

* Add visualizer capability and build directive.

* Remove rollup from dependency list completely!

Co-authored-by: Bryan Housel <bhousel@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Remove special case for push to deploy_with_action

This was just used during development

* Clean up log, and add link to build result

* One too many slashes

* Is this simple conditional good enough?

* Better syntax?

* Now with correct syntax

* Bump osm-community-index from 5.0.1 to 5.1.0

Bumps [osm-community-index](https://github.com/osmlab/osm-community-index) from 5.0.1 to 5.1.0.
- [Release notes](https://github.com/osmlab/osm-community-index/releases)
- [Changelog](https://github.com/osmlab/osm-community-index/blob/main/CHANGELOG.md)
- [Commits](osmlab/osm-community-index@v5.0.1...v5.1.0)

---
updated-dependencies:
- dependency-name: osm-community-index
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump osm-community-index from 5.0.1 to 5.1.0

* If locationSet is missing `include`, default to worldwide include
openstreetmap/iD#8305 (comment)

* pacify eslint, fix merge goof in map.js

* Build sourcemap too

* Use pagination to fetch all the esri datasets
(closes #257)

* Bump object-inspect from 1.10.3 to 1.11.0

Bumps [object-inspect](https://github.com/inspect-js/object-inspect) from 1.10.3 to 1.11.0.
- [Release notes](https://github.com/inspect-js/object-inspect/releases)
- [Commits](inspect-js/object-inspect@v1.10.3...v1.11.0)

---
updated-dependencies:
- dependency-name: object-inspect
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* gitignore esbuild.json
It changes on every build and is only use to rebuild the stats

* Bump osm-community-index to 5.1.1

* Modernize more scripts
(convert require to import)

* npm run imagery

* npm run translations

* rapid-v1.1.5

* Set z-index of absolutely positioned layers under supersurface
Each of these has their own internal stacking context

* npm run translations

* Fix link

* Math/extent conversion (#272)

* Bump version to newest id-sdk release.

* Convert geoExtent to id-sdk/Extent. Most tests working.

* Fix remaining tests.

* Remove geo modules no longer in use.

* Revert "Fix remaining tests."

This reverts commit 7ba89ce.

* Fix a number of instances of extents being used as raw tuples.

* Woops- converted zoom/pan functionality that interacts with d3. NOT a candidate for Extent() conversion.

* Fix roads/ways not appearing in the map, also fix a crossing ways test problem.

* Fix an issue with the measurement panel not setting its extent correctly.

* fix usages of Extend.extend() because it no longer modifies the extent in-place.

* Fix copy / paste bug that falsely claimed everything had an extent of +/- Infinity.

* add service module for querying streetview suggestions (#192)

* Show suggestion images and viewfield icon

* fix PR comments

* hightlight images and viewfields on hover

* Sort images by increasing longitude, so that the left-rightness of images matches the flow of the map points as we scan left->right.

* Add image strip as separate component (still quite buggy). Fix the two-way binding between image fields and images in the strip so that hover/select highlights correctly.

* Fix the image filmstrip so that it is properly shut off / redisplayed as the user hovers over / moves off a sidewalk.

* Fix bug that was selecting the wrong service when we selected a sidewalk suggestion.

* Get image strip working with Bryan's help.

* Fix sorting of images by longitude.

* Improve styling of the image strip, and add 'enlarge on mouse hover' interaction.

* style suggested sidewalks

* Parse crosswalk data

* remove console.log statement

* Fix debug messages that shouldn't have been checked in.

* Fix issue that was causing too many viewfield nodes to appear.

* fix hovering issues

* Fix some linter errors.

* Make 5 images not require a scrollbar in the image strip, even when one is zoomed.

* Fix images to all have the same height, not the same width.

* Fix code drift issues that had occurred in main.

Co-authored-by: Milos Brzakovic (E-Search) <mbrzakovic@microsoft.com>
Co-authored-by: Bryan Housel <bhousel@gmail.com>
Co-authored-by: Nikola Pleša <nikolaplesa@fb.com>
Co-authored-by: Milos Brzakovic <78906108+mbrzakovic@users.noreply.github.com>
Co-authored-by: Danny Krause <vanreece@gmail.com>
Co-authored-by: Ben Clark <bennyc@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Xiaoming Gao <mkobie@gmail.com>
Co-authored-by: Amol Vasant Khadilkar <amolk@fb.com>
Co-authored-by: Benjamin Clark <clarkben@fb.com>

Author: 9 people

.github/workflows/build.yml

@@ -25,4 +25,13 @@ jobs:
         node-version: ${{ matrix.node-version }}
     - run: npm install
     - run: npm run all
-    - run: npm run test
+    - run: npm run test
+    - run: npm run aws_deploy
+      env:
+        AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
+        AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+        AWS_DEFAULT_REGION: us-west-2
+        RAPID_S3_BUCKET_NAME: world.ai.rapid
+        RAPID_WEB_ROOT: https://mapwith.ai
+        NODE_VERSION: ${{ matrix.node-version }}
+      if: ${{ matrix.node-version == '16.x' }}

.gitignore

@@ -12,6 +12,7 @@ transifex.auth
 /dist/*.js
 /dist/*.css
 /dist/*.map
+/dist/esbuild.json
 /dist/data/
 /dist/img/*.svg
 /dist/locales/en.min.json

.npmrc

@@ -0,0 +1 @@
+node-options="--no-warnings --experimental-json-modules"

CHANGELOG.md

@@ -1,13 +1,13 @@
 # What's New
 
-Thanks to all our contributors, users, and the many people that make RapiD possible! :heart:
+Thanks to all our contributors, users, and the many people that make RapiD possible! ❤️
 
 The RapiD map editor is an open source project. You can submit bug reports, help out,
 or learn more by visiting our project page on GitHub:  :octocat: https://github.com/facebookincubator/RapiD
 
-If you love RapiD, please star our project on GitHub to show your support! :star:
+If you love RapiD, please star our project on GitHub to show your support! ⭐️
 
-_Breaking developer changes, which may affect downstream projects or sites that embed RapiD, are marked with a_ :warning:
+_Breaking developer changes, which may affect downstream projects or sites that embed RapiD, are marked with a_ ⚠️
 
 <!--
 # A.B.C
@@ -37,6 +37,35 @@ _Breaking developer changes, which may affect downstream projects or sites that
 [@xxxx]: https://github.com/xxxx
 -->
 
+# [1.1.5](https://github.com/facebookincubator/RapiD/releases/tag/rapid-v1.1.5)
+##### 2021-Jul-13
+#### :tada: Updates
+* Name Suggestion Index v6.0
+* OSM Community Index v5.1
+* D3.js v7.0
+* Mapillary API and Mapillary-JS Viewer v4.0 ([#233], [#236])
+* Add new duplicate way validation ([#220])
+
+#### :hammer: Development
+* Replace rollup with esbuild for much faster project builds ([#246])
+
+#### :bug: Bugfixes
+* Remove artificial limit of 100 on Esri Datasets ([#257], [#265])
+* Ensure freshness of Bing Imagery ([iD#8570])
+* If locationSet is missing include, default to worldwide include ([iD#bfb36d5])
+* Fix bug in walkthrough ([#234])
+
+[#220]: https://github.com/facebookincubator/RapiD/issues/220
+[#233]: https://github.com/facebookincubator/RapiD/issues/233
+[#234]: https://github.com/facebookincubator/RapiD/issues/234
+[#236]: https://github.com/facebookincubator/RapiD/issues/236
+[#246]: https://github.com/facebookincubator/RapiD/issues/246
+[#257]: https://github.com/facebookincubator/RapiD/issues/257
+[#265]: https://github.com/facebookincubator/RapiD/issues/265
+[iD#8570]: https://github.com/openstreetmap/iD/issues/8570
+[iD#bfb36d5]: https://github.com/openstreetmap/iD/pull/8305/commits/bfb36d572d35271f1a77227d776ebddc7f232ac3
+
+
 # [1.1.4](https://github.com/facebookincubator/RapiD/releases/tag/rapid-v1.1.4)
 ##### 2021-May-14
 #### :tada: Updates

babel.config.json

@@ -2,12 +2,22 @@
   "presets": [
     [
       "@babel/preset-env", {
-        "useBuiltIns": "usage",
-        "corejs": 3,
-        "modules": false
+        "useBuiltIns": "entry",
+         "corejs": 3,
+        "modules": false,
+        "targets": {
+          "chrome": "58",
+          "ie": 11
+        }
       }
     ],
     "@babel/preset-react"
   ],
+  "plugins": [
+    "inline-json-import",
+    ["@babel/transform-runtime", {
+      "regenerator": true
+    }]
+  ],
   "compact": false
 }

config/esbuild.config.legacy.js

@@ -0,0 +1,20 @@
+import esbuild from 'esbuild';
+import babel from 'esbuild-plugin-babel';
+
+esbuild
+    .build({
+        entryPoints: ['./modules/id.js'],
+        bundle: true,
+        outfile: 'dist/iD.legacy.js',
+        metafile: true,
+        plugins: [babel({
+            filter: /.*/,
+            namespace: '',
+            babelHelpers: 'bundled',
+            // avoid circular dependencies due to `useBuiltIns: usage` option
+            exclude: [/\/core-js\//],
+            sourceType: 'unambiguous',
+        })],
+         target: ['es5']
+    })
+    .catch(() => process.exit(1));

css/80_app.css

@@ -4146,8 +4146,15 @@ img.tile-debug {
     bottom: 0;
 }
 
+
+.supersurface .layer.layer-background {
+    z-index: 1;
+}
+.supersurface .layer.layer-overlay {
+    z-index: 2;
+}
 .supersurface .layer.layer-data {
-    z-index: 30;  /* above imagery, overlays */
+    z-index: 3;
 }
 
 /* Map-In-Map

data/core.yaml

@@ -1426,11 +1426,27 @@ en:
     title: "Map Features"
     tooltip: "Map features from Mapillary"
     construction:
+      barrier:
+        temporary: temporary barrier
       flat:
         crosswalk_plain: plain crosswalk
+        driveway: driveway
     marking:
       discrete:
-        crosswalk_zebra: zebra crosswalk
+        arrow:
+          left: lane marking - arrow (left)
+          right: lane marking - arrow (right)
+          split_left_or_straight: lane marking - arrow (split left or straight)
+          split_right_or_straight: lane marking - arrow (split right or straight)
+          straight: lane marking - arrow (straight)
+        crosswalk_zebra: lane marking - crosswalk
+        give_way_row: lane marking - give way (row)
+        give_way_single: lane marking - give way (single)
+        other_marking: lane marking - other
+        stop_line: lane marking - stop line
+        symbol:
+          bicycle: lane marking - symbol (bicycle)
+        text: lane marking - text
     object:
       banner: banner
       bench: bench
@@ -1439,15 +1455,24 @@ en:
       catch_basin: catch basin
       cctv_camera: CCTV camera
       fire_hydrant: fire hydrant
+      junction_box: junction box
       mailbox: mailbox
       manhole: manhole
+      parking_meter: parking meter
       phone_booth: phone booth
       sign:
         advertisement: advertisement
         information: information sign
+        other: other sign
         store: shop sign
+        traffic_sign:
+          back: traffic sign - back
+          direction_front: traffic sign - front
+          front: traffic sign - front
       street_light: street light
       support:
+        pole: pole
+        traffic_sign_frame: traffic sign frame
         utility_pole: utility pole
       traffic_cone: traffic cone
       traffic_light:
@@ -1458,6 +1483,7 @@ en:
         other: traffic light
         pedestrians: pedestrian traffic light
       trash_can: trash can
+      water_valve: water valve
   mapillary:
     title: Mapillary
     signs: