Skip to content

Commit e41beff

Browse files
committed
Revert "fix ignoreDeprecations usage"
This reverts commit 0e7014a.
1 parent 0e7014a commit e41beff

3 files changed

Lines changed: 6 additions & 29 deletions

File tree

.github/workflows/tests-e2e.yml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -158,28 +158,18 @@ jobs:
158158
working-directory: ../test-website
159159
env:
160160
E2E_TEST: true
161-
162161
- name: TypeCheck website
163162
# TODO: there're some lingering issues with PnP + tsc. Enable tsc in PnP later.
164163
if: matrix.variant == '-st' && matrix.nodeLinker != 'pnp'
165164
working-directory: ../test-website
166165
run: yarn typecheck
167-
168166
- name: TypeCheck website - min version - v5.1
169167
# TODO: there're some lingering issues with PnP + tsc. Enable tsc in PnP later.
170168
if: matrix.variant == '-st' && matrix.nodeLinker != 'pnp'
171169
working-directory: ../test-website
172170
run: |
173171
yarn add typescript@5.1.6 --exact
174-
175-
# Downgrade TS ignoreDeprecations option
176-
jq '.compilerOptions.ignoreDeprecations = "5.0"' tsconfig.json > tsconfig.json.tmp && mv -f tsconfig.json.tmp tsconfig.json
177-
178172
yarn typecheck
179-
180-
# Restore TS ignoreDeprecations option
181-
jq '.compilerOptions.ignoreDeprecations = "6.0"' tsconfig.json > tsconfig.json.tmp && mv -f tsconfig.json.tmp tsconfig.json
182-
183173
- name: TypeCheck website - max version - Latest
184174
# TODO: there're some lingering issues with PnP + tsc. Enable tsc in PnP later.
185175
if: matrix.variant == '-st' && matrix.nodeLinker != 'pnp'

.github/workflows/tests-windows.yml

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -61,23 +61,18 @@ jobs:
6161
- name: TypeCheck website
6262
# see https://github.com/facebook/docusaurus/pull/10486
6363
run: yarn workspace website typecheck
64-
65-
- name: TypeCheck website - max version - Latest
66-
# For latest TS there are often lib check errors, so we disable it
67-
# Details: https://github.com/facebook/docusaurus/pull/10486
68-
run: |
69-
yarn add typescript@latest --exact -D -W --ignore-scripts
70-
yarn workspace website typecheck --project tsconfig.skipLibCheck.json
71-
7264
- name: TypeCheck website - min version - v5.1
7365
run: |
7466
yarn add typescript@5.1.6 --exact -D -W --ignore-scripts
7567
76-
# Downgrade TS ignoreDeprecations option
77-
jq '.compilerOptions.ignoreDeprecations = "5.0"' tsconfig.json > tsconfig.json.tmp && mv -Force tsconfig.json.tmp tsconfig.json
78-
7968
# DocSearch@4/ai@5 doesn't support TS 5.1 (with skipLibCheck=false)
8069
jq '.resolutions."@docsearch/react" = "^3.9.0"' package.json > package.json.tmp && mv -Force package.json.tmp package.json
8170
yarn add @docsearch/react@^3.9.0 --exact -D -W --ignore-scripts
8271
8372
yarn workspace website typecheck
73+
- name: TypeCheck website - max version - Latest
74+
# For latest TS there are often lib check errors, so we disable it
75+
# Details: https://github.com/facebook/docusaurus/pull/10486
76+
run: |
77+
yarn add typescript@latest --exact -D -W --ignore-scripts
78+
yarn workspace website typecheck --project tsconfig.skipLibCheck.json

.github/workflows/tests.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,23 +58,15 @@ jobs:
5858
- name: TypeCheck website
5959
# see https://github.com/facebook/docusaurus/pull/10486
6060
run: yarn workspace website typecheck
61-
6261
- name: TypeCheck website - min version - v5.1
6362
run: |
6463
yarn add typescript@5.1.6 --exact -D -W --ignore-scripts
6564
66-
# Downgrade TS ignoreDeprecations option
67-
jq '.compilerOptions.ignoreDeprecations = "5.0"' tsconfig.json > tsconfig.json.tmp && mv -f tsconfig.json.tmp tsconfig.json
68-
6965
# DocSearch@4/ai@5 doesn't support TS 5.1 (with skipLibCheck=false)
7066
jq '.resolutions."@docsearch/react" = "^3.9.0"' package.json > package.json.tmp && mv -f package.json.tmp package.json
7167
yarn add @docsearch/react@^3.9.0 --exact -D -W --ignore-scripts
7268
7369
yarn workspace website typecheck
74-
75-
# Restore TS ignoreDeprecations option
76-
jq '.compilerOptions.ignoreDeprecations = "6.0"' tsconfig.json > tsconfig.json.tmp && mv -f tsconfig.json.tmp tsconfig.json
77-
7870
- name: TypeCheck website - max version - Latest
7971
# For latest TS there are often lib check errors, so we disable it
8072
# Details: https://github.com/facebook/docusaurus/pull/10486

0 commit comments

Comments
 (0)