Commit 441f7fc
Deprecate TestUsersManager
Summary:
This type exists to make it easier to work with the Graph API to provide test user accounts.
A few reasons to get rid of this:
1. It's shipped as production code but really just exists for setting up integration tests. This is clearly wrong.
2. It's generally not the SDKs job to maintain specific calls to endpoints (outside of a few specific use cases such as login and app events). CoreKit should only implement the specific graph requests that are required to enable a user to form their own graph requests.
3. This is easily implemented by anyone who is currently using it. The internal CoreKit import can be replaced by
```
#import "FBSDKCoreKit_Basics.h"
#import "FBSDKCoreKit.h"
```
4. Graph API usage suggests that barely anyone is using this type. Effectively 0% usage.
Reviewed By: KylinChang
Differential Revision: D26915949
fbshipit-source-id: 9218d23f04c6008d151a142887fbcf1d0ce48ce51 parent 83c8dfe commit 441f7fc
2 files changed
Lines changed: 9 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
| 32 | + | |
32 | 33 | | |
33 | 34 | | |
34 | 35 | | |
| |||
44 | 45 | | |
45 | 46 | | |
46 | 47 | | |
| 48 | + | |
47 | 49 | | |
48 | 50 | | |
49 | 51 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
23 | 27 | | |
24 | 28 | | |
25 | 29 | | |
| |||
336 | 340 | | |
337 | 341 | | |
338 | 342 | | |
| 343 | + | |
| 344 | + | |
0 commit comments