fix: add macosx support to build-ios-framework-rn.sh and update CI

Address review feedback:
- Add macosx to get_architecture, get_deployment_target,
  create_framework, and build_universal_framework in the -rn script
- Route macosx through build-ios-framework-rn.sh in CI instead of
  build-mac-framework-rn.sh
- Simplify get_architecture from 5 branches to 2

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: Saadnajmi

.github/workflows/build-apple-slices-hermes.yml

@@ -45,17 +45,8 @@ jobs:
           # HermesC is used to build hermes, so it has to be executable
           chmod +x ./build_host_hermesc/bin/hermesc
 
-          if [[ "$SLICE" == "macosx" ]]; then
-            echo "[HERMES] Building Hermes for MacOS"
-
-            chmod +x ./utils/build-mac-framework-rn.sh
-            BUILD_TYPE="${{ matrix.flavor }}" ./utils/build-mac-framework-rn.sh
-          else
-            echo "[HERMES] Building Hermes for iOS: $SLICE"
-
-            chmod +x ./utils/build-ios-framework-rn.sh
-            BUILD_TYPE="${{ matrix.flavor }}" ./utils/build-ios-framework-rn.sh "$SLICE"
-          fi
+          chmod +x ./utils/build-ios-framework-rn.sh
+          BUILD_TYPE="${{ matrix.flavor }}" ./utils/build-ios-framework-rn.sh "$SLICE"
 
           echo "Moving from build_$SLICE to $FINAL_PATH"
           mv build_"$SLICE" "$FINAL_PATH"

utils/build-ios-framework-rn.sh

@@ -12,15 +12,9 @@ set -e
 # Given a specific target, retrieve the right architecture for it
 # $1 the target you want to build. Allowed values: iphoneos, iphonesimulator, catalyst, xros, xrsimulator
 function get_architecture {
-    if [[ $1 == "iphoneos" || $1 == "xros" ]]; then
+    if [[ $1 == "iphoneos" || $1 == "appletvos" || $1 == "xros" ]]; then
       echo "arm64"
-    elif [[ $1 == "iphonesimulator" || $1 == "xrsimulator" ]]; then
-      echo "x86_64;arm64"
-    elif [[ $1 == "appletvos" ]]; then
-      echo "arm64"
-    elif [[ $1 == "appletvsimulator" ]]; then
-      echo "x86_64;arm64"
-    elif [[ $1 == "catalyst" ]]; then
+    elif [[ $1 == "iphonesimulator" || $1 == "appletvsimulator" || $1 == "catalyst" || $1 == "macosx" || $1 == "xrsimulator" ]]; then
       echo "x86_64;arm64"
     else
       echo "Error: unknown architecture passed $1"
@@ -29,7 +23,9 @@ function get_architecture {
 }
 
 function get_deployment_target {
-    if [[ $1 == "xros" || $1 == "xrsimulator" ]]; then
+    if [[ $1 == "macosx" ]]; then
+      echo "$(get_mac_deployment_target)"
+    elif [[ $1 == "xros" || $1 == "xrsimulator" ]]; then
       echo "$(get_visionos_deployment_target)"
     else # tvOS and iOS use the same deployment target
       echo "$(get_ios_deployment_target)"
@@ -53,7 +49,7 @@ function build_framework {
 # group the frameworks together to create a universal framework
 function build_universal_framework {
     if [ ! -d destroot/Library/Frameworks/universal/hermesvm.xcframework ]; then
-        create_universal_framework "iphoneos" "iphonesimulator" "catalyst" "xros" "xrsimulator" "appletvos" "appletvsimulator"
+        create_universal_framework "macosx" "iphoneos" "iphonesimulator" "catalyst" "xros" "xrsimulator" "appletvos" "appletvsimulator"
     else
         echo "Skipping; Clean \"destroot\" to rebuild".
     fi
@@ -63,6 +59,7 @@ function build_universal_framework {
 # this is used to preserve backward compatibility
 function create_framework {
     if [ ! -d destroot/Library/Frameworks/universal/hermesvm.xcframework ]; then
+        build_framework "macosx"
         build_framework "iphoneos"
         build_framework "iphonesimulator"
         build_framework "appletvos"