fix: route macosx through build-ios-framework.sh and simplify get_architecture

Address review feedback:
- Remove macosx conditional in CI — all slices now go through
  build-ios-framework.sh since it handles macosx
- Simplify get_architecture from 5 branches to 2

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: Saadnajmi

.github/workflows/build-apple-slices-hermes.yml

@@ -55,17 +55,8 @@ jobs:
         # HermesC is used to build hermes, so it has to be executable
         chmod +x ./build_host_hermesc/bin/hermesc
 
-        if [[ "$SLICE" == "macosx" ]]; then
-          echo "[HERMES] Building Hermes for MacOS"
-
-          chmod +x ./utils/build-mac-framework.sh
-          BUILD_TYPE="${{ matrix.flavor }}" ./utils/build-mac-framework.sh
-        else
-          echo "[HERMES] Building Hermes for iOS: $SLICE"
-
-          chmod +x ./utils/build-ios-framework.sh
-          BUILD_TYPE="${{ matrix.flavor }}" ./utils/build-ios-framework.sh "$SLICE"
-        fi
+        chmod +x ./utils/build-ios-framework.sh
+        BUILD_TYPE="${{ matrix.flavor }}" ./utils/build-ios-framework.sh "$SLICE"
 
         echo "Moving from build_$SLICE to $FINAL_PATH"
         mv build_"$SLICE" "$FINAL_PATH"

utils/build-ios-framework.sh

@@ -12,15 +12,9 @@ set -e
 # Given a specific target, retrieve the right architecture for it
 # $1 the target you want to build. Allowed values: iphoneos, iphonesimulator, catalyst, xros, xrsimulator
 function get_architecture {
-    if [[ $1 == "iphoneos" || $1 == "xros" ]]; then
+    if [[ $1 == "iphoneos" || $1 == "appletvos" || $1 == "xros" ]]; then
       echo "arm64"
-    elif [[ $1 == "iphonesimulator" || $1 == "xrsimulator" ]]; then
-      echo "x86_64;arm64"
-    elif [[ $1 == "appletvos" ]]; then
-      echo "arm64"
-    elif [[ $1 == "appletvsimulator" ]]; then
-      echo "x86_64;arm64"
-    elif [[ $1 == "catalyst" || $1 == "macosx" ]]; then
+    elif [[ $1 == "iphonesimulator" || $1 == "appletvsimulator" || $1 == "catalyst" || $1 == "macosx" || $1 == "xrsimulator" ]]; then
       echo "x86_64;arm64"
     else
       echo "Error: unknown architecture passed $1"