chore: fix some type errors in e2e tests (#9720)

Author: SimenB

e2e/__tests__/coverageReport.test.ts

@@ -30,7 +30,7 @@ test('outputs coverage report', () => {
   //  with 0 % coverage.
   expect(wrap(stdout)).toMatchSnapshot();
 
-  expect(() => fs.accessSync(coverageDir, fs.F_OK)).not.toThrow();
+  expect(() => fs.accessSync(coverageDir, fs.constants.F_OK)).not.toThrow();
   expect(exitCode).toBe(0);
 });
 

e2e/__tests__/env.test.ts

@@ -5,9 +5,9 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-import runJest from '../runJest';
+import runJest, {RunJestResult} from '../runJest';
 
-const getLog = result => result.stdout.split('\n')[1].trim();
+const getLog = (result: RunJestResult) => result.stdout.split('\n')[1].trim();
 
 describe('Environment override', () => {
   it('uses jsdom when specified', () => {

e2e/__tests__/hasteMapMockChanged.test.ts

@@ -6,7 +6,7 @@
  */
 
 import * as path from 'path';
-import JestHasteMap from 'jest-haste-map';
+import JestHasteMap = require('jest-haste-map');
 import {cleanup, writeFiles} from '../Utils';
 
 // Directory must be here for Watchman to be enabled.

e2e/__tests__/hasteMapSha1.test.ts

@@ -7,7 +7,7 @@
 
 import {tmpdir} from 'os';
 import * as path from 'path';
-import JestHasteMap from 'jest-haste-map';
+import JestHasteMap = require('jest-haste-map');
 import {cleanup, writeFiles} from '../Utils';
 
 const DIR = path.resolve(tmpdir(), 'haste_map_sha1');

e2e/__tests__/jsonReporter.test.ts

@@ -7,6 +7,7 @@
 
 import * as fs from 'fs';
 import * as path from 'path';
+import type {FormattedTestResults} from '@jest/test-result';
 import runJest from '../runJest';
 
 describe('JSON Reporter', () => {
@@ -22,7 +23,7 @@ describe('JSON Reporter', () => {
   });
 
   it('writes test result to sum.result.json', () => {
-    let jsonResult;
+    let jsonResult: FormattedTestResults;
 
     runJest('json-reporter', ['--json', `--outputFile=${outputFileName}`]);
     const testOutput = fs.readFileSync(outputFilePath, 'utf8');
@@ -45,7 +46,7 @@ describe('JSON Reporter', () => {
     const noAncestors = jsonResult.testResults[0].assertionResults.find(
       item => item.title == 'no ancestors',
     );
-    let expected = {ancestorTitles: []};
+    let expected = {ancestorTitles: [] as Array<string>};
     expect(noAncestors).toEqual(expect.objectContaining(expected));
 
     const addsNumbers = jsonResult.testResults[0].assertionResults.find(
@@ -63,7 +64,7 @@ describe('JSON Reporter', () => {
 
   it('outputs coverage report', () => {
     const result = runJest('json-reporter', ['--json']);
-    let jsonResult;
+    let jsonResult: FormattedTestResults;
 
     expect(result.stderr).toMatch(/1 failed, 2 passed/);
     expect(result.exitCode).toBe(1);
@@ -86,7 +87,7 @@ describe('JSON Reporter', () => {
     const noAncestors = jsonResult.testResults[0].assertionResults.find(
       item => item.title == 'no ancestors',
     );
-    let expected = {ancestorTitles: []};
+    let expected = {ancestorTitles: [] as Array<string>};
     expect(noAncestors).toEqual(expect.objectContaining(expected));
 
     const addsNumbers = jsonResult.testResults[0].assertionResults.find(

e2e/__tests__/listTests.test.ts

@@ -11,7 +11,7 @@ import runJest from '../runJest';
 
 const testRootDir = path.resolve(__dirname, '..', '..');
 
-const normalizePaths = rawPaths =>
+const normalizePaths = (rawPaths: string) =>
   rawPaths
     .split(testRootDir)
     .join(`${path.sep}MOCK_ABOLUTE_PATH`)

e2e/__tests__/nodePath.test.ts

@@ -9,7 +9,7 @@ import runJest from '../runJest';
 
 test('supports NODE_PATH', () => {
   const result = runJest('node-path', [], {
-    nodePath: ['../node-path/src'],
+    nodePath: '../node-path/src',
   });
   expect(result.exitCode).toBe(0);
 });

e2e/__tests__/overrideGlobals.test.ts

@@ -18,7 +18,7 @@ test('has a duration even if time is faked', () => {
 
   expect(stderr).toMatch(regex);
 
-  const [, duration] = stderr.match(regex);
+  const [, duration] = stderr.match(regex)!;
 
   expect(Number(duration)).toBeGreaterThan(0);
 });

e2e/__tests__/showConfig.test.ts

@@ -37,8 +37,8 @@ test('--showConfig outputs config info and exits', () => {
     .replace(/"name": "(.+)"/g, '"name": "[md5 hash]"')
     .replace(/"version": "(.+)"/g, '"version": "[version]"')
     .replace(/"maxWorkers": (\d+)/g, '"maxWorkers": "[maxWorkers]"')
-    .replace(/\"\S*show-config-test/gm, '"<<REPLACED_ROOT_DIR>>')
-    .replace(/\"\S*\/jest\/packages/gm, '"<<REPLACED_JEST_PACKAGES_DIR>>');
+    .replace(/"\S*show-config-test/gm, '"<<REPLACED_ROOT_DIR>>')
+    .replace(/"\S*\/jest\/packages/gm, '"<<REPLACED_JEST_PACKAGES_DIR>>');
 
   expect(wrap(stdout)).toMatchSnapshot();
 });

e2e/__tests__/testEnvironment.test.ts

@@ -7,7 +7,7 @@
 
 import {json as runWithJson} from '../runJest';
 
-import testFixturePackage from '../test-environment/package.json';
+import * as testFixturePackage from '../test-environment/package.json';
 
 it('respects testEnvironment docblock', () => {
   expect(testFixturePackage.jest.testEnvironment).toEqual('node');