Skip to content

Fix unhandled ERR_IPC_CHANNEL_CLOSED and a deadlock#11144

Merged
SimenB merged 1 commit intojestjs:masterfrom
xamgore:patch-2
Mar 7, 2021
Merged

Fix unhandled ERR_IPC_CHANNEL_CLOSED and a deadlock#11144
SimenB merged 1 commit intojestjs:masterfrom
xamgore:patch-2

Conversation

@xamgore
Copy link
Copy Markdown
Contributor

@xamgore xamgore commented Mar 3, 2021

The detailed description is at #11143.

Fixes #11143

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #11144 (b259724) into master (78af379) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11144      +/-   ##
==========================================
+ Coverage   64.18%   64.20%   +0.01%     
==========================================
  Files         307      307              
  Lines       13370    13370              
  Branches     3262     3262              
==========================================
+ Hits         8582     8584       +2     
+ Misses       4083     4082       -1     
+ Partials      705      704       -1     
Impacted Files Coverage Δ
...ages/jest-worker/src/workers/ChildProcessWorker.ts 90.36% <100.00%> (ø)
packages/expect/src/utils.ts 96.12% <0.00%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78af379...b259724. Read the comment docs.

@@ -205,6 +205,7 @@ export default class ChildProcessWorker implements WorkerInterface {
private _onExit(exitCode: number) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private _onExit(exitCode: number) {
private _onExit(exitCode: number | null) {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged it, thanks!

Copy link
Copy Markdown
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog entry and Tim's type suggestion and I think we're good to go 🙂

@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unhandled ERR_IPC_CHANNEL_CLOSED exception and a deadlock in jest-worker

5 participants