Exclude files from running if they match with the ignoring pattern#5341
Merged
mjesun merged 1 commit intojestjs:masterfrom Jan 18, 2018
mjesun:mpr-blacklist
Merged
Exclude files from running if they match with the ignoring pattern#5341mjesun merged 1 commit intojestjs:masterfrom mjesun:mpr-blacklist
mjesun merged 1 commit intojestjs:masterfrom
mjesun:mpr-blacklist
Conversation
Member
|
Could you rebase so we can see that sweet green checkmark? |
…hen run via file mode)
SimenB
approved these changes
Jan 18, 2018
Codecov Report
@@ Coverage Diff @@
## master #5341 +/- ##
==========================================
- Coverage 61.35% 61.32% -0.03%
==========================================
Files 205 205
Lines 6906 6909 +3
Branches 4 4
==========================================
Hits 4237 4237
- Misses 2668 2671 +3
Partials 1 1
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking the existence of a file into a project via getting all files from haste is not enough. The reason for that is that a parent project might have a child project inside it, which all of its files explicitly blacklisted.
I've added an extra refinement step, where the full file paths are run through the
testPathIgnorePatternsmethod, and returningfalseif they match (note: the result of the method is reversed, so the!in front of the call is correct).I also changed the test to create this particular use case, and verified that it fails on master but passes on the PR. Added entry in
CHANGELOG.mdas well.It might also potentially fix #5332.