Add testPath to suite in jest-jasmine2 reporter callbacks

[Vanuan]

Summary

Add testPath to jest-jasmine2 reporter callbacks.

Before:

{
      id: 'suite0',
      description: 'tests',
      fullName: '',
      failedExpectations: [],
}

After

      id: 'suite0',
      description: 'tests',
      fullName: '',
      failedExpectations: [],
      testPath: '/src/__tests__/foo.test.js' 

Test plan
See #4594

[codecov-io]

Codecov Report

Merging #5394 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #5394      +/-   ##
==========================================
- Coverage   61.32%   61.31%   -0.02%     
==========================================
  Files         205      205              
  Lines        6925     6927       +2     
  Branches        3        3              
==========================================
  Hits         4247     4247              
- Misses       2677     2679       +2     
  Partials        1        1

Impacted Files	Coverage Δ
packages/jest-jasmine2/src/jasmine/Suite.js	0% <ø> (ø)	⬆️
packages/jest-jasmine2/src/jasmine/Env.js	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c243f67...58e1806. Read the comment docs.

[SimenB]

Mind adding a test so we don't break it when removing jasmine?

[cpojer]

Ping @Vanuan Mind adding a test?

[Vanuan]

Current tests already cover this code. Similar PR from @palmerj3 didn't have any additional tests so I don't know how to do it.

Are you saying jasmine would be removed? I'd like to use it like this:

const jasmineReporters = require('jasmine-reporters');

jasmine.getEnv().addReporter(
        new jasmineReporters.JUnitXmlReporter({
                // Jest runs many instances of Jasmine in parallel.
                // Force distinct file output
                // per test to avoid collisions.
                modifyReportFileName: function(name, suite) {
                  return `${suite.testPath.replace("/", "_")}-${name}`;
                }
...

Maybe there's a simpler way to safely write JUnit report files?

[SimenB]

We have a future goal (on the backburner for now) of removing jasmine, replacing it with jest-circus.

For JUnit xml in particular, you can use https://www.npmjs.com/package/jest-junit. Might be that this PR in particular is related to their one open issue, though: https://github.com/palmerj3/jest-junit/issues/39 🙂

[SimenB]

Seeing as the other PR was merged without tests, we can probably merge this as well

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.